Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1444705

Re: [patch] mtd: maps: sa1100-flash: potential NULL dereference

Show all headers | View raw

On Fri, Jul 15, 2016 at 05:32:09PM -0700, Brian Norris wrote:
> + stable
> 
> Hi Dan,
> 
> Patch looks good, but one question.
> 
> On Fri, Jul 15, 2016 at 02:06:30PM +0300, Dan Carpenter wrote:
> > We check for NULL but then dereference "info->mtd" on the next line.
> > 
> > Fixes: 72169755cf36 ('mtd: maps: sa1100-flash: show parent device in sysfs')
> 
> What am I supposed to do about tags like this? It appears that the
> -stable folks have started taking patches with a 'Fixes' tag alone [0],
> even though that's not mentioned in [1]. I ask because I strongly
> suspect this patch doesn't fit the rules in [1] -- it quite likely has
> only been compile tested; and it qualifies quite well as violating
> bullet 4:
> 
> """
>  - It must fix a real bug that bothers people (not a, "This could be a
>    problem..." type thing).
> """
> 
> So, I'd like to keep the tag, but I'd like to avoid having to NAK it in
> the stable review process. (And really, I often don't care enough to
> even do that. I believe there's a very low chance that something like
> this would cause additional problems more than the original bug.)

Only sometimes will I pick up something that only has a fixes: tag in
it, not all the time, I try to review the patch to see if it does match
the rules or not.

But, fixing an oops is a good thing, I'm sure you can figure out how to
trigger it otherwise you would not be taking such a patch as it would be
not be needed :)

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [patch] mtd: maps: sa1100-flash: potential NULL dereference Brian Norris <computersforpeace@gmail.com> - 2016-07-16 02:40 +0200
  Re: [patch] mtd: maps: sa1100-flash: potential NULL dereference Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-07-16 02:50 +0200
    Re: [patch] mtd: maps: sa1100-flash: potential NULL dereference Brian Norris <computersforpeace@gmail.com> - 2016-07-16 03:50 +0200
  Re: [patch] mtd: maps: sa1100-flash: potential NULL dereference Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-16 11:10 +0200
    Re: [patch] mtd: maps: sa1100-flash: potential NULL dereference Brian Norris <computersforpeace@gmail.com> - 2016-07-17 06:00 +0200

csiph-web