Re: [PATCH 3/4] qcom: ipq4019: ASoC tlmm/pinctrl support

From	Andy Gross <andy.gross@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] qcom: ipq4019: ASoC tlmm/pinctrl support
Date	2016-07-15 22:30 +0200
Message-ID	<rVhUd-2YB-3@gated-at.bofh.it> (permalink)
References	<rV5q1-3U6-9@gated-at.bofh.it> <rV5q2-3U6-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 15, 2016 at 12:37:05PM +0530, njaigane@codeaurora.org wrote:
> From: Jaiganesh Narayanan <njaigane@codeaurora.org>
> 
> This patch adds the tlmm/pinctrl support for IPQ4019 ASoC.
> 
> Signed-off-by: Jaiganesh Narayanan <njaigane@codeaurora.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-ipq4019.c | 116 +++++++++++++++++++++++++--------
>  1 file changed, 88 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> index b68ae42..bc22597 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2015, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2015-2016, The Linux Foundation. All rights reserved.
>   *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License version 2 and
> @@ -283,6 +283,18 @@ enum ipq4019_functions {
>  	qca_mux_blsp_uart0,
>  	qca_mux_blsp_spi1,
>  	qca_mux_blsp_spi0,
> +	qca_mux_i2s_rx_mclk,
> +	qca_mux_i2s_rx_bclk,
> +	qca_mux_i2s_rx_fsync,
> +	qca_mux_i2s_rxd,
> +	qca_mux_i2s_tx_mclk,
> +	qca_mux_i2s_tx_bclk,
> +	qca_mux_i2s_tx_fsync,
> +	qca_mux_i2s_txd1,
> +	qca_mux_i2s_txd2,
> +	qca_mux_i2s_txd3,
> +	qca_mux_i2s_spdif_out,
> +	qca_mux_i2s_spdif_in,

You'll also need to add all of these to the
Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt

I was also going to suggest just using qca_i2s and having a single function, but
it seems like there is at least 1 pin that supports more than one i2s mode.

Regards,
Andy

Thread

[PATCH 0/4] Qualcomm IPQ4019 Audio driver addition njaigane@codeaurora.org - 2016-07-15 09:10 +0200
  [PATCH 1/4] qcom: ipq4019: Add ipq4019 ASoC device tree changes njaigane@codeaurora.org - 2016-07-15 09:10 +0200
    Re: [PATCH 1/4] qcom: ipq4019: Add ipq4019 ASoC device tree changes Rob Herring <robh@kernel.org> - 2016-07-17 22:10 +0200
  [PATCH 3/4] qcom: ipq4019: ASoC tlmm/pinctrl support njaigane@codeaurora.org - 2016-07-15 09:10 +0200
    Re: [PATCH 3/4] qcom: ipq4019: ASoC tlmm/pinctrl support Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-07-15 21:20 +0200
    Re: [PATCH 3/4] qcom: ipq4019: ASoC tlmm/pinctrl support Andy Gross <andy.gross@linaro.org> - 2016-07-15 22:30 +0200
  Re: [PATCH 4/4] qcom: ipq4019: Add ASoC driver modules Mark Brown <broonie@kernel.org> - 2016-07-15 15:00 +0200
  Re: [PATCH 0/4] Qualcomm IPQ4019 Audio driver addition Mark Brown <broonie@kernel.org> - 2016-07-15 15:00 +0200

csiph-web