Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1444273

Re: [PATCH 4/4] qcom: ipq4019: Add ASoC driver modules

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 4/4] qcom: ipq4019: Add ASoC driver modules
Date 2016-07-15 15:00 +0200
Message-ID <rVaSK-70X-3@gated-at.bofh.it> (permalink)
References <rV5q1-3U6-9@gated-at.bofh.it> <rV5q1-3U6-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, Jul 15, 2016 at 12:37:06PM +0530, njaigane@codeaurora.org wrote:

>  sound/soc/qcom/Kconfig                     |  47 ++
>  sound/soc/qcom/Makefile                    |   1 +
>  sound/soc/qcom/ipq4019/Makefile            |  16 +
>  sound/soc/qcom/ipq4019/ipq4019-adss.c      | 407 ++++++++++++++
>  sound/soc/qcom/ipq4019/ipq4019-adss.h      | 432 +++++++++++++++
>  sound/soc/qcom/ipq4019/ipq4019-codec.c     | 475 +++++++++++++++++
>  sound/soc/qcom/ipq4019/ipq4019-codec.h     |  91 ++++
>  sound/soc/qcom/ipq4019/ipq4019-cpu-dai.c   | 687 ++++++++++++++++++++++++
>  sound/soc/qcom/ipq4019/ipq4019-mbox.c      | 825 +++++++++++++++++++++++++++++
>  sound/soc/qcom/ipq4019/ipq4019-mbox.h      | 146 +++++
>  sound/soc/qcom/ipq4019/ipq4019-pcm-i2s.c   | 609 +++++++++++++++++++++
>  sound/soc/qcom/ipq4019/ipq4019-pcm-spdif.c | 664 +++++++++++++++++++++++
>  sound/soc/qcom/ipq4019/ipq4019-pcm-tdm.c   | 609 +++++++++++++++++++++
>  sound/soc/qcom/ipq4019/ipq4019-pcm.h       |  37 ++
>  sound/soc/qcom/ipq4019/ipq4019-stereo.c    | 313 +++++++++++
>  sound/soc/qcom/ipq4019/ipq4019.c           | 121 +++++

This is *far* too big to be a single patch.  Please at the very least
split this up into one patch per driver, look at the git history of
other drivers for examples of splitting things up.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] Qualcomm IPQ4019 Audio driver addition njaigane@codeaurora.org - 2016-07-15 09:10 +0200
  [PATCH 1/4] qcom: ipq4019: Add ipq4019 ASoC device tree changes njaigane@codeaurora.org - 2016-07-15 09:10 +0200
    Re: [PATCH 1/4] qcom: ipq4019: Add ipq4019 ASoC device tree changes Rob Herring <robh@kernel.org> - 2016-07-17 22:10 +0200
  [PATCH 3/4] qcom: ipq4019: ASoC tlmm/pinctrl support njaigane@codeaurora.org - 2016-07-15 09:10 +0200
    Re: [PATCH 3/4] qcom: ipq4019: ASoC tlmm/pinctrl support Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-07-15 21:20 +0200
    Re: [PATCH 3/4] qcom: ipq4019: ASoC tlmm/pinctrl support Andy Gross <andy.gross@linaro.org> - 2016-07-15 22:30 +0200
  Re: [PATCH 4/4] qcom: ipq4019: Add ASoC driver modules Mark Brown <broonie@kernel.org> - 2016-07-15 15:00 +0200
  Re: [PATCH 0/4] Qualcomm IPQ4019 Audio driver addition Mark Brown <broonie@kernel.org> - 2016-07-15 15:00 +0200

csiph-web