Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling

Path	csiph.com!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Nicolas Dufresne <nicolas@ndufresne.ca>
Newsgroups	linux.kernel
Subject	Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling
Date	Fri, 15 Jul 2016 19:10:01 +0200
Message-ID	<rVeMF-19a-5@gated-at.bofh.it> (permalink)
References	<rg1Dj-30H-15@gated-at.bofh.it> <rqmQ9-1lx-13@gated-at.bofh.it> <rVeCZ-QX-13@gated-at.bofh.it>
X-Original-To	Javier Martinez Canillas <javier@osg.samsung.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>
Reply-To	nicolas@ndufresne.ca
Content-Type	multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-ykrAIx091FSnLflAVduC"
X-Mailer	Evolution 3.20.3 (3.20.3-1.fc24)
MIME-Version	1.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	52
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Mauro Carvalho Chehab <mchehab@osg.samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, Kukjin Kim <kgene@kernel.org>, Andreas Färber <afaerber@suse.de>, linux-media@vger.kernel.org
X-Original-Date	Fri, 15 Jul 2016 13:05:25 -0400
X-Original-Message-ID	<1468602325.3819.6.camel@ndufresne.ca>
X-Original-References	<1458780100-8865-1-git-send-email-javier@osg.samsung.com> <5718D3DC.20004@osg.samsung.com> <1468601608.3819.4.camel@ndufresne.ca>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1444456

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Le vendredi 15 juillet 2016 à 12:53 -0400, Nicolas Dufresne a écrit :
> Le jeudi 21 avril 2016 à 09:21 -0400, Javier Martinez Canillas a
> écrit :
> > Hello Sylwester,
> > 
> > On 03/23/2016 08:41 PM, Javier Martinez Canillas wrote:
> > > The same struct device_node * is used for looking up the I2C
> > > sensor, OF
> > > graph endpoint and port. So the reference count is incremented
> > > but
> > > not
> > > decremented for the endpoint and port nodes.
> > > 
> > > Fix this by having separate pointers for each node looked up.
> > > 
> > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > > 
> > 
> > Any comments about this patch?
> 
> Tested-by: Nicolas Dufresne <nicoas.dufresne@collabora.com>

There a typo here.

Tested-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> 
> Note: I could not verify that leak is gone, but I could verify that
> this driver is still working properly after the change.
> 
> > 
> > Best regards,

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFT PATCH v2] [media] exynos4-is: Fix  fimc_is_parse_sensor_config() nodes handling Nicolas Dufresne <nicolas@ndufresne.ca> - 2016-07-15 19:00 +0200
  Re: [RFT PATCH v2] [media] exynos4-is: Fix  fimc_is_parse_sensor_config() nodes handling Nicolas Dufresne <nicolas@ndufresne.ca> - 2016-07-15 19:10 +0200

csiph-web