Re: [PATCH 29/66] tools lib traceevent: Use str_error_r()

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 29/66] tools lib traceevent: Use str_error_r()
Date	2016-07-17 20:50 +0200
Message-ID	<rVZix-4fE-3@gated-at.bofh.it> (permalink)
References	(5 earlier) <rUsRH-3OH-25@gated-at.bofh.it> <rUxRo-7iM-17@gated-at.bofh.it> <rUyDM-7RI-33@gated-at.bofh.it> <rUDDr-2G8-5@gated-at.bofh.it> <rUDN7-2JJ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 13, 2016 at 10:39:09PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 13, 2016 at 09:25:50PM -0400, Steven Rostedt escreveu:
> > On Wed, 13 Jul 2016 17:01:48 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > > perf, trace-cmd/kernelshark, powertop and ras-daemon  
> > > 
> > > Cool, so this is all just about tools/lib/traceevent/ after all, sure,
> > > go ahead, you're the "external source" after all :-)
> > 
> > Great! We're on the same page then ;-)
> 
> It took a while, now it seems so :-)

heya,
after discussing this with Arnaldo I checked the possibility
of adding traceevent as a fedora kernel rpm subpackage..

and to my surprise fedora already has following rpms:
(see attached rpm -ql output for list of their files)

  kernel-tools
  kernel-tools-libs
  kernel-tools-libs-devel

I wonder we could solve all this by adding traceevent
lib into kernel-libs and kernel-libs-devel packages.

I tried and with easy change to fedora kernel.spec made following rpm:

---
[jolsa@krava fedora]$ rpm -ql -p /home/jolsa/rpmbuild/RPMS/x86_64/kernel-tools-libs-devel-4.7.0-0.rc7.git3.1.fc22.x86_64.rpm
/usr/include/cpufreq.h
/usr/lib64/libcpupower.so
/usr/lib64/libtraceevent.a
/usr/lib64/libtraceevent.so
/usr/lib64/traceevent/plugins/plugin_cfg80211.so
/usr/lib64/traceevent/plugins/plugin_function.so
/usr/lib64/traceevent/plugins/plugin_hrtimer.so
/usr/lib64/traceevent/plugins/plugin_jbd2.so
/usr/lib64/traceevent/plugins/plugin_kmem.so
/usr/lib64/traceevent/plugins/plugin_kvm.so
/usr/lib64/traceevent/plugins/plugin_mac80211.so
/usr/lib64/traceevent/plugins/plugin_sched_switch.so
/usr/lib64/traceevent/plugins/plugin_scsi.so
/usr/lib64/traceevent/plugins/plugin_xen.so
---

we'll need to make some enhancements to install targets
to provide header files and *.so.VERSION files.. and some
other minor things

the kernel-tools-libs file could looks like (haven't made this one):
---
[jolsa@krava fedora]$ rpm -ql kernel-tools-libs
/usr/lib64/libcpupower.so.0
/usr/lib64/libcpupower.so.0.0.0
/usr/lib64/libtraceevent.so.0
/usr/lib64/libtraceevent.so.0.0.0
---

I haven't checked other distro's kernel packages
but I guess it'll be similar

this way we export traceevent lib for other users and its
source stays in the kernel

thoughts? ;-)
jirka



---
[jolsa@krava fedora]$ rpm -qa kernel-tools
kernel-tools-4.4.14-200.fc22.x86_64
[jolsa@krava fedora]$ rpm -ql kernel-tools
/etc/sysconfig/cpupower
/usr/bin/centrino-decode
/usr/bin/cpupower
/usr/bin/powernow-k8-decode
/usr/bin/tmon
/usr/bin/turbostat
/usr/bin/x86_energy_perf_policy
/usr/lib/systemd/system/cpupower.service
/usr/share/locale/cs/LC_MESSAGES/cpupower.mo
/usr/share/locale/de/LC_MESSAGES/cpupower.mo
/usr/share/locale/fr/LC_MESSAGES/cpupower.mo
/usr/share/locale/it/LC_MESSAGES/cpupower.mo
/usr/share/locale/pt/LC_MESSAGES/cpupower.mo
/usr/share/man/man1/cpupower-frequency-info.1.gz
/usr/share/man/man1/cpupower-frequency-set.1.gz
/usr/share/man/man1/cpupower-idle-info.1.gz
/usr/share/man/man1/cpupower-idle-set.1.gz
/usr/share/man/man1/cpupower-info.1.gz
/usr/share/man/man1/cpupower-monitor.1.gz
/usr/share/man/man1/cpupower-set.1.gz
/usr/share/man/man1/cpupower.1.gz
/usr/share/man/man8/turbostat.8.gz
/usr/share/man/man8/x86_energy_perf_policy.8.gz
[jolsa@krava fedora]$ rpm -ql kernel-tools-libs
/usr/lib64/libcpupower.so.0
/usr/lib64/libcpupower.so.0.0.0
[jolsa@krava fedora]$ rpm -ql kernel-tools-libs-devel
/usr/include/cpufreq.h
/usr/lib64/libcpupower.so
[jolsa@krava fedora]$

Thread

[PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-13 01:00 +0200
  Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-13 01:20 +0200
    Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Steven Rostedt <rostedt@goodmis.org> - 2016-07-13 01:30 +0200
      Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-13 01:40 +0200
        Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Steven Rostedt <rostedt@goodmis.org> - 2016-07-13 14:40 +0200
          Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-13 16:00 +0200
            Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Steven Rostedt <rostedt@goodmis.org> - 2016-07-13 21:20 +0200
              Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-13 22:10 +0200
                Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Steven Rostedt <rostedt@goodmis.org> - 2016-07-14 03:30 +0200
                Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-14 03:40 +0200
                Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Jiri Olsa <jolsa@redhat.com> - 2016-07-17 20:50 +0200
  Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Steven Rostedt <rostedt@goodmis.org> - 2016-07-13 01:20 +0200

csiph-web