Groups > linux.kernel > #1441918

Re: [PATCH 29/66] tools lib traceevent: Use str_error_r()

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 29/66] tools lib traceevent: Use str_error_r()
Date	2016-07-13 01:40 +0200
Message-ID	<rUfrs-3kN-3@gated-at.bofh.it> (permalink)
References	<rUeF3-2Ns-3@gated-at.bofh.it> <rUeOJ-2RS-1@gated-at.bofh.it> <rUf85-3eh-5@gated-at.bofh.it> <rUf85-3eh-7@gated-at.bofh.it> <rUfhL-3hH-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Tue, Jul 12, 2016 at 07:25:19PM -0400, Steven Rostedt escreveu:
> On Tue, 12 Jul 2016 20:14:24 -0300
> Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> 
> > Em Tue, Jul 12, 2016 at 07:11:08PM -0400, Steven Rostedt escreveu:
> > > On Tue, 12 Jul 2016 19:40:04 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote:  
> > > > To make it portable to non-glibc systems, that follow the XSI variant
> > > > instead of the GNU specific one that gets in place when _GNU_SOURCE is
> > > > defined.  
> > 
> > > >  #include "event-parse.h"
> > > > @@ -6131,12 +6132,7 @@ int pevent_strerror(struct pevent *pevent __maybe_unused,
> > > > +		str_error_r(errnum, buf, buflen);
> > > >  		return 0;  

> > > What library is used with this? When I port this over to trace-cmd
> > > (which is still needed as I develop this there), it fails to build.
> > > "undefined reference to str_error_r"  

> > tools/lib/str_error_r.c

> > Forgot about the out of tree copy :-\
 
> Yeah, we really need to make this into a real library. I haven't had
> the time to do that. Hopefully in August I can talk with some people at

What exactly do you mean by that? To grab a copy of what is in tools/
and have it turned into a library somewhere else?

Or to freeze its interfaces and create an .so with a committed to ABI?

I kind of like the way it is now... :-)

> LinuxCon to see the best way to go about doing that.
> 
> Anyway, I may just take that file and port it to trace-cmd.

Yeah, that would solve this specific case.

- Arnaldo

Thread

[PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-13 01:00 +0200
  Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-13 01:20 +0200
    Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Steven Rostedt <rostedt@goodmis.org> - 2016-07-13 01:30 +0200
      Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-13 01:40 +0200
        Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Steven Rostedt <rostedt@goodmis.org> - 2016-07-13 14:40 +0200
          Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-13 16:00 +0200
            Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Steven Rostedt <rostedt@goodmis.org> - 2016-07-13 21:20 +0200
              Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-13 22:10 +0200
                Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Steven Rostedt <rostedt@goodmis.org> - 2016-07-14 03:30 +0200
                Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-14 03:40 +0200
                Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Jiri Olsa <jolsa@redhat.com> - 2016-07-17 20:50 +0200
  Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Steven Rostedt <rostedt@goodmis.org> - 2016-07-13 01:20 +0200

csiph-web