Re: [patch] video: fbdev: pxafb: potential NULL dereference on error

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [patch] video: fbdev: pxafb: potential NULL dereference on error
Date	2016-07-17 17:30 +0200
Message-ID	<rVWaZ-2s2-3@gated-at.bofh.it> (permalink)
References	<rV9jX-6dN-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Dan Carpenter <dan.carpenter@oracle.com> writes:

> If we "goto out;" then it calls display_timings_release(timings);
> Since "timings" is NULL, that's going to oops.  Just return directly.
>
> Fixes: 420a488278e8 ('video: fbdev: pxafb: initial devicetree conversion')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch] video: fbdev: pxafb: potential NULL dereference on error Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-15 13:20 +0200
  Re: [patch] video: fbdev: pxafb: potential NULL dereference on error Robert Jarzmik <robert.jarzmik@free.fr> - 2016-07-17 17:30 +0200

csiph-web