[patch] video: fbdev: pxafb: potential NULL dereference on error

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] video: fbdev: pxafb: potential NULL dereference on error
Date	2016-07-15 13:20 +0200
Message-ID	<rV9jX-6dN-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If we "goto out;" then it calls display_timings_release(timings);
Since "timings" is NULL, that's going to oops.  Just return directly.

Fixes: 420a488278e8 ('video: fbdev: pxafb: initial devicetree conversion')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index 2c0487f..ed41fdb 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -2125,7 +2125,7 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp,
 
 	timings = of_get_display_timings(disp);
 	if (!timings)
-		goto out;
+		return -EINVAL;
 
 	ret = -ENOMEM;
 	info->modes = kmalloc_array(timings->num_timings,

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] video: fbdev: pxafb: potential NULL dereference on error Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-15 13:20 +0200
  Re: [patch] video: fbdev: pxafb: potential NULL dereference on error Robert Jarzmik <robert.jarzmik@free.fr> - 2016-07-17 17:30 +0200

csiph-web