Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445035

RE: [PATCH v3 6/8] thunderbolt: Networking state machine

Show all headers | View raw

On Fri, Jul 15 2016, 03:25 AM, Paul Gortmaker wrote:
> > diff --git a/drivers/thunderbolt/icm/net.c
> > b/drivers/thunderbolt/icm/net.c new file mode 100644 index
> > 0000000..e983dfb
> > --- /dev/null
> > +++ b/drivers/thunderbolt/icm/net.c
> > @@ -0,0 +1,802 @@
> >
> +/*********************************************************
> ***********
> > +***********
> > + *
> > + * Intel Thunderbolt(TM) driver
> > + * Copyright(c) 2014 - 2016 Intel Corporation.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > +modify it
> > + * under the terms and conditions of the GNU General Public License,
> > + * version 2, as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope it will be useful, but
> > +WITHOUT
> > + * ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY
> > +or
> > + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
> > +License for
> > + * more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > +along
> > + * with this program.  If not, see <http://www.gnu.org/licenses/>.
> > + *
> > + * The full GNU General Public License is included in this
> > +distribution in
> > + * the file called "COPYING".
> > + *
> > + * Contact Information:
> > + * Intel Thunderbolt Mailing List <thunderbolt-software@lists.01.org>
> > + * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR
> > +97124-6497
> > + *
> > +
> >
> +*********************************************************
> ************
> > +*********/
> > +
> > +#include <linux/module.h>
> 
> I did not see anything like module_init in this driver;  I think it seems like you
> want linux/moduleparam.h here.
> 

Hi Paul,
It looks like leftover from the early development stages.
I'll remove it.
The module_init is in icm_nhi.c.

Thanks,
Amir

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/8] thunderbolt: Introducing Thunderbolt(TM) networking Amir Levy <amir.jer.levy@intel.com> - 2016-07-14 13:30 +0200
  [PATCH v3 2/8] thunderbolt: Updating device IDs Amir Levy <amir.jer.levy@intel.com> - 2016-07-14 13:40 +0200
    Re: [PATCH v3 2/8] thunderbolt: Updating device IDs David Miller <davem@davemloft.net> - 2016-07-15 20:50 +0200
      RE: [PATCH v3 2/8] thunderbolt: Updating device IDs "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-15 21:00 +0200
        Re: [PATCH v3 2/8] thunderbolt: Updating device IDs David Miller <davem@davemloft.net> - 2016-07-16 00:00 +0200
          RE: [PATCH v3 2/8] thunderbolt: Updating device IDs "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-18 12:00 +0200
  RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM  (firmware) "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-14 17:00 +0200
    RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM  (firmware) "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-07-16 10:50 +0200
  RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM  (firmware) "Rosen, Rami" <rami.rosen@intel.com> - 2016-07-14 17:10 +0200
    RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM  (firmware) "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-14 20:40 +0200
      RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM  (firmware) "Rosen, Rami" <rami.rosen@intel.com> - 2016-07-14 21:10 +0200
  Re: [PATCH v3 6/8] thunderbolt: Networking state machine Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-15 02:30 +0200
    RE: [PATCH v3 6/8] thunderbolt: Networking state machine "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-17 09:10 +0200

csiph-web