RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

From	"Rosen, Rami" <rami.rosen@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)
Date	2016-07-14 21:10 +0200
Message-ID	<rUUbg-5bU-23@gated-at.bofh.it> (permalink)
References	<rUN05-BW-3@gated-at.bofh.it> <rUN07-BW-35@gated-at.bofh.it> <rUOfw-1kh-9@gated-at.bofh.it> <rUQr0-2Rf-29@gated-at.bofh.it> <rUTIe-4Mw-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Amir,

>This patch is the communication with the FW.
>The network functionality is added in the next patches in the series 
>and with it, more messages from FW.
>Indeed this function always returns true in this patch, 
>but while writing it, I predicted that the network functionality will 
>use the send_event flag differently.
>You can see the documentation of send_event - currently unused in this patch.
>I don't see any harm that in this patch, this function will always return true,
>while applying the rest of the series will change it.

Ok, seems reasonable.

>The prototype of suspend is return int:
>http://lxr.free-electrons.com/source/include/linux/pm.h#L295

>The prototype of resume is return int:
>http://lxr.free-electrons.com/source/include/linux/pm.h#L295

You are right about this, I missed the macro invocation in your code, SET_SYSTEM_SLEEP_PM_OPS(nhi_suspend, nhi_resume),
apologies.

 Regards,
 Rami Rosen
 Intel Corporation

Thread

[PATCH v3 0/8] thunderbolt: Introducing Thunderbolt(TM) networking Amir Levy <amir.jer.levy@intel.com> - 2016-07-14 13:30 +0200
  [PATCH v3 2/8] thunderbolt: Updating device IDs Amir Levy <amir.jer.levy@intel.com> - 2016-07-14 13:40 +0200
    Re: [PATCH v3 2/8] thunderbolt: Updating device IDs David Miller <davem@davemloft.net> - 2016-07-15 20:50 +0200
      RE: [PATCH v3 2/8] thunderbolt: Updating device IDs "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-15 21:00 +0200
        Re: [PATCH v3 2/8] thunderbolt: Updating device IDs David Miller <davem@davemloft.net> - 2016-07-16 00:00 +0200
          RE: [PATCH v3 2/8] thunderbolt: Updating device IDs "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-18 12:00 +0200
  RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM  (firmware) "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-14 17:00 +0200
    RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM  (firmware) "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-07-16 10:50 +0200
  RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM  (firmware) "Rosen, Rami" <rami.rosen@intel.com> - 2016-07-14 17:10 +0200
    RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM  (firmware) "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-14 20:40 +0200
      RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM  (firmware) "Rosen, Rami" <rami.rosen@intel.com> - 2016-07-14 21:10 +0200
  Re: [PATCH v3 6/8] thunderbolt: Networking state machine Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-15 02:30 +0200
    RE: [PATCH v3 6/8] thunderbolt: Networking state machine "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2016-07-17 09:10 +0200

csiph-web