Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1442862

[PATCH net-next 2/2] devlink: fix trace format string

Show all headers | View raw

Including devlink.h on ARM and probably other 32-bit architectures results in
a harmless warning:

In file included from ../include/trace/define_trace.h:95:0,
                 from ../include/trace/events/devlink.h:51,
                 from ../net/core/devlink.c:30:
include/trace/events/devlink.h: In function 'trace_raw_output_devlink_hwmsg':
include/trace/events/devlink.h:42:12: error: format '%lu' expects argument of type 'long unsigned int', but argument 10 has type 'size_t {aka unsigned int}' [-Werror=format=]

The correct format string for 'size_t' is %zu, not %lu, this works on all
architectures.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: e5224f0fe2ac ("devlink: add hardware messages tracing facility")
---
 include/trace/events/devlink.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h
index 26f92d3c7e9c..4b75a6f986fc 100644
--- a/include/trace/events/devlink.h
+++ b/include/trace/events/devlink.h
@@ -47,7 +47,7 @@ TRACE_EVENT(devlink_hwmsg,
 		__entry->len = len;
 	),
 
-	TP_printk("bus_name=%s dev_name=%s owner_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%lu",
+	TP_printk("bus_name=%s dev_name=%s owner_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%zu",
 		  __get_str(bus_name), __get_str(dev_name),
 		  __get_str(owner_name), __entry->incoming, __entry->type,
 		  (int) __entry->len, __get_dynamic_array(buf), __entry->len)
-- 
2.9.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n Arnd Bergmann <arnd@arndb.de> - 2016-07-13 23:10 +0200
  [PATCH net-next 2/2] devlink: fix trace format string Arnd Bergmann <arnd@arndb.de> - 2016-07-13 23:10 +0200
  Re: [PATCH net-next 1/2] devlink: fix build error for  CONFIG_MODULES=n Jiri Pirko <jiri@resnulli.us> - 2016-07-14 08:30 +0200
    Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n Arnd Bergmann <arnd@arndb.de> - 2016-07-14 10:20 +0200
      Re: [PATCH net-next 1/2] devlink: fix build error for  CONFIG_MODULES=n Jiri Pirko <jiri@resnulli.us> - 2016-07-14 11:00 +0200

csiph-web