Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1443184

Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n
Date 2016-07-14 10:20 +0200
Message-ID <rUK2n-75j-259@gated-at.bofh.it> (permalink)
References <rUzzQ-8ue-37@gated-at.bofh.it> <rUIjL-5Tv-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thursday, July 14, 2016 8:21:11 AM CEST Jiri Pirko wrote:
> >diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h
> >index 333c32ac9bfa..26f92d3c7e9c 100644
> >--- a/include/trace/events/devlink.h
> >+++ b/include/trace/events/devlink.h
> >@@ -22,7 +22,11 @@ TRACE_EVENT(devlink_hwmsg,
> >       TP_STRUCT__entry(
> >               __string(bus_name, devlink->dev->bus->name)
> >               __string(dev_name, dev_name(devlink->dev))
> >+#ifdef CONFIG_MODULES
> >               __string(owner_name, devlink->dev->driver->owner->name)
> 
> I think would be better to use driver->name. I looks like it is always
> present. I will do some tests and send a patch.
> 

Yes, good idea.

	Arnd

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n Arnd Bergmann <arnd@arndb.de> - 2016-07-13 23:10 +0200
  [PATCH net-next 2/2] devlink: fix trace format string Arnd Bergmann <arnd@arndb.de> - 2016-07-13 23:10 +0200
  Re: [PATCH net-next 1/2] devlink: fix build error for  CONFIG_MODULES=n Jiri Pirko <jiri@resnulli.us> - 2016-07-14 08:30 +0200
    Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n Arnd Bergmann <arnd@arndb.de> - 2016-07-14 10:20 +0200
      Re: [PATCH net-next 1/2] devlink: fix build error for  CONFIG_MODULES=n Jiri Pirko <jiri@resnulli.us> - 2016-07-14 11:00 +0200

csiph-web