Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1442494

Re: [PATCH v15 03/12] perf tools: Update perf evlist mmap related APIs and helpers

Show all headers | View raw

On Tue, Jul 12, 2016 at 10:00:03AM +0000, Wang Nan wrote:

SNIP

> -union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist, int idx)
> +union perf_event *perf_mmap__read_forward(struct perf_mmap *md, bool overwrite)
>  {
> -	struct perf_mmap *md = &evlist->mmap[idx];
>  	u64 head;
>  	u64 old = md->prev;
>  
> @@ -795,13 +795,12 @@ union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist, int
>  
>  	head = perf_mmap__read_head(md);
>  
> -	return perf_mmap__read(md, evlist->overwrite, old, head, &md->prev);
> +	return perf_mmap__read(md, overwrite, old, head, &md->prev);
>  }
>  
>  union perf_event *
> -perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx)
> +perf_mmap__read_backward(struct perf_mmap *md, bool overwrite __maybe_unused)
>  {
> -	struct perf_mmap *md = &evlist->mmap[idx];
>  	u64 head, end;
>  	u64 start = md->prev;
>  
> @@ -836,6 +835,20 @@ perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx)
>  	return perf_mmap__read(md, false, start, end, &md->prev);

should you pas evlist->overwrite in here?

thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v15 00/12] perf tools: Support overwritable ring buffer Wang Nan <wangnan0@huawei.com> - 2016-07-12 12:10 +0200
  [PATCH v15 01/12] perf tools: Drop redundant evsel->overwrite indicator Wang Nan <wangnan0@huawei.com> - 2016-07-12 12:10 +0200
  [PATCH v15 03/12] perf tools: Update perf evlist mmap related APIs and helpers Wang Nan <wangnan0@huawei.com> - 2016-07-12 12:10 +0200
    Re: [PATCH v15 03/12] perf tools: Update perf evlist mmap related  APIs and helpers Jiri Olsa <jolsa@redhat.com> - 2016-07-13 16:10 +0200
      Re: [PATCH v15 03/12] perf tools: Update perf evlist mmap related  APIs and helpers "Wangnan (F)" <wangnan0@huawei.com> - 2016-07-14 04:00 +0200

csiph-web