Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1442291

[PATCH 4/4] mm: move most file-based accounting to the node -fix

From Mel Gorman <mgorman@techsingularity.net>
Newsgroups linux.kernel
Subject [PATCH 4/4] mm: move most file-based accounting to the node -fix
Date 2016-07-13 12:10 +0200
Message-ID <rUph8-1FZ-29@gated-at.bofh.it> (permalink)
References <rUph7-1FZ-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


As noted by Johannes Weiner, NR_ZONE_WRITE_PENDING gets decremented twice
during migration instead of a dec(old) -> inc(new) cycle as intended.

This is a fix to mmotm patch
mm-move-most-file-based-accounting-to-the-node.patch

Note that it'll cause a conflict with
mm-vmstat-remove-zone-and-node-double-accounting-by-approximating-retries.patch
but that the resolution is trivial.

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
 mm/migrate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index c77997dc6ed7..ed0268268e93 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -515,7 +515,7 @@ int migrate_page_move_mapping(struct address_space *mapping,
 			__dec_node_state(oldzone->zone_pgdat, NR_FILE_DIRTY);
 			__dec_zone_state(oldzone, NR_ZONE_WRITE_PENDING);
 			__inc_node_state(newzone->zone_pgdat, NR_FILE_DIRTY);
-			__dec_zone_state(newzone, NR_ZONE_WRITE_PENDING);
+			__inc_zone_state(newzone, NR_ZONE_WRITE_PENDING);
 		}
 	}
 	local_irq_enable();
-- 
2.6.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] Follow-up fixes to node-lru series v1 Mel Gorman <mgorman@techsingularity.net> - 2016-07-13 12:10 +0200
  [PATCH 2/4] mm: vmstat: account per-zone stalls and pages skipped during reclaim -fix Mel Gorman <mgorman@techsingularity.net> - 2016-07-13 12:10 +0200
    Re: [PATCH 2/4] mm: vmstat: account per-zone stalls and pages  skipped during reclaim -fix Johannes Weiner <hannes@cmpxchg.org> - 2016-07-13 15:20 +0200
    Re: [PATCH 2/4] mm: vmstat: account per-zone stalls and pages skipped  during reclaim -fix Vlastimil Babka <vbabka@suse.cz> - 2016-07-14 16:50 +0200
  [PATCH 1/4] mm, vmscan: Have kswapd reclaim from all zones if reclaiming and buffer_heads_over_limit -fix Mel Gorman <mgorman@techsingularity.net> - 2016-07-13 12:10 +0200
    Re: [PATCH 1/4] mm, vmscan: Have kswapd reclaim from all zones if  reclaiming and buffer_heads_over_limit -fix Johannes Weiner <hannes@cmpxchg.org> - 2016-07-13 15:20 +0200
    Re: [PATCH 1/4] mm, vmscan: Have kswapd reclaim from all zones if  reclaiming and buffer_heads_over_limit -fix Minchan Kim <minchan@kernel.org> - 2016-07-14 03:30 +0200
  [PATCH 3/4] mm, page_alloc: fix dirtyable highmem calculation Mel Gorman <mgorman@techsingularity.net> - 2016-07-13 12:10 +0200
    Re: [PATCH 3/4] mm, page_alloc: fix dirtyable highmem calculation Johannes Weiner <hannes@cmpxchg.org> - 2016-07-13 15:20 +0200
    Re: [PATCH 3/4] mm, page_alloc: fix dirtyable highmem calculation Vlastimil Babka <vbabka@suse.cz> - 2016-07-14 17:30 +0200
  [PATCH 4/4] mm: move most file-based accounting to the node -fix Mel Gorman <mgorman@techsingularity.net> - 2016-07-13 12:10 +0200
    Re: [PATCH 4/4] mm: move most file-based accounting to the node -fix Johannes Weiner <hannes@cmpxchg.org> - 2016-07-13 15:20 +0200

csiph-web