Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1442287

[PATCH 2/4] mm: vmstat: account per-zone stalls and pages skipped during reclaim -fix

From Mel Gorman <mgorman@techsingularity.net>
Newsgroups linux.kernel
Subject [PATCH 2/4] mm: vmstat: account per-zone stalls and pages skipped during reclaim -fix
Date 2016-07-13 12:10 +0200
Message-ID <rUph8-1FZ-13@gated-at.bofh.it> (permalink)
References <rUph7-1FZ-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


As pointed out by Johannes -- the PG prefix seems to stand for page, and
all stat names that contain it represent some per-page event. PGSTALL is
not a page event. This patch renames it.

This is a fix for the mmotm patch
mm-vmstat-account-per-zone-stalls-and-pages-skipped-during-reclaim.patch

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
 include/linux/vm_event_item.h | 2 +-
 mm/vmscan.c                   | 2 +-
 mm/vmstat.c                   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
index 6d47f66f0e9c..4d6ec58a8d45 100644
--- a/include/linux/vm_event_item.h
+++ b/include/linux/vm_event_item.h
@@ -23,7 +23,7 @@
 
 enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
 		FOR_ALL_ZONES(PGALLOC),
-		FOR_ALL_ZONES(PGSTALL),
+		FOR_ALL_ZONES(ALLOCSTALL),
 		FOR_ALL_ZONES(PGSCAN_SKIP),
 		PGFREE, PGACTIVATE, PGDEACTIVATE,
 		PGFAULT, PGMAJFAULT,
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 21eae17ee730..429bf3a9c06c 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2674,7 +2674,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
 	delayacct_freepages_start();
 
 	if (global_reclaim(sc))
-		__count_zid_vm_events(PGSTALL, sc->reclaim_idx, 1);
+		__count_zid_vm_events(ALLOCSTALL, sc->reclaim_idx, 1);
 
 	do {
 		vmpressure_prio(sc->gfp_mask, sc->target_mem_cgroup,
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 7415775faf08..91ecca96dcae 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -980,7 +980,7 @@ const char * const vmstat_text[] = {
 	"pswpout",
 
 	TEXTS_FOR_ZONES("pgalloc")
-	TEXTS_FOR_ZONES("pgstall")
+	TEXTS_FOR_ZONES("allocstall")
 	TEXTS_FOR_ZONES("pgskip")
 
 	"pgfree",
-- 
2.6.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] Follow-up fixes to node-lru series v1 Mel Gorman <mgorman@techsingularity.net> - 2016-07-13 12:10 +0200
  [PATCH 2/4] mm: vmstat: account per-zone stalls and pages skipped during reclaim -fix Mel Gorman <mgorman@techsingularity.net> - 2016-07-13 12:10 +0200
    Re: [PATCH 2/4] mm: vmstat: account per-zone stalls and pages  skipped during reclaim -fix Johannes Weiner <hannes@cmpxchg.org> - 2016-07-13 15:20 +0200
    Re: [PATCH 2/4] mm: vmstat: account per-zone stalls and pages skipped  during reclaim -fix Vlastimil Babka <vbabka@suse.cz> - 2016-07-14 16:50 +0200
  [PATCH 1/4] mm, vmscan: Have kswapd reclaim from all zones if reclaiming and buffer_heads_over_limit -fix Mel Gorman <mgorman@techsingularity.net> - 2016-07-13 12:10 +0200
    Re: [PATCH 1/4] mm, vmscan: Have kswapd reclaim from all zones if  reclaiming and buffer_heads_over_limit -fix Johannes Weiner <hannes@cmpxchg.org> - 2016-07-13 15:20 +0200
    Re: [PATCH 1/4] mm, vmscan: Have kswapd reclaim from all zones if  reclaiming and buffer_heads_over_limit -fix Minchan Kim <minchan@kernel.org> - 2016-07-14 03:30 +0200
  [PATCH 3/4] mm, page_alloc: fix dirtyable highmem calculation Mel Gorman <mgorman@techsingularity.net> - 2016-07-13 12:10 +0200
    Re: [PATCH 3/4] mm, page_alloc: fix dirtyable highmem calculation Johannes Weiner <hannes@cmpxchg.org> - 2016-07-13 15:20 +0200
    Re: [PATCH 3/4] mm, page_alloc: fix dirtyable highmem calculation Vlastimil Babka <vbabka@suse.cz> - 2016-07-14 17:30 +0200
  [PATCH 4/4] mm: move most file-based accounting to the node -fix Mel Gorman <mgorman@techsingularity.net> - 2016-07-13 12:10 +0200
    Re: [PATCH 4/4] mm: move most file-based accounting to the node -fix Johannes Weiner <hannes@cmpxchg.org> - 2016-07-13 15:20 +0200

csiph-web