Re: [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error
Date	2016-07-13 10:00 +0200
Message-ID	<rUnfk-8tL-23@gated-at.bofh.it> (permalink)
References	<rU6xR-5Z5-41@gated-at.bofh.it> <rUhjz-4ys-3@gated-at.bofh.it> <rU6xR-5Z5-39@gated-at.bofh.it> <rUhjz-4ys-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/13/2016 03:35 AM, Jaehoon Chung wrote:
> Hi Krzysztof,
> 
> On 07/12/2016 11:08 PM, Krzysztof Kozlowski wrote:
>> The commit 97f659a2e972 ("mmc: dw_mmc: prevent to set the wrong
>> value") reordered the code so the 'uhs' variable used in
>> mmc_regulator_set_vqmmc() error message is always 0 at that time thus
>> always printing 3.3 voltage.  Instead use value obtained from ios in
>> printed error message.
> 
> The commit 97f659a2e972 was dropped because some board didn't work fine.
> Some boards didn't use the vqmmc suppy and not defined into device-tree.
> 
> It's short time to fix. I will re-send the patch on next.
> At that time, i will check this patch.

Ah, okay. If 97f659a2e972 is dropped, there is no need for this patchset.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] mmc: dw_mmc: Print proper voltage on error Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-12 16:10 +0200
  Re: [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error Jaehoon Chung <jh80.chung@samsung.com> - 2016-07-13 03:40 +0200
    Re: [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-13 10:00 +0200

csiph-web