Groups > linux.kernel > #1441950

Re: [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error

From	Jaehoon Chung <jh80.chung@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error
Date	2016-07-13 03:40 +0200
Message-ID	<rUhjz-4ys-1@gated-at.bofh.it> (permalink)
References	<rU6xR-5Z5-41@gated-at.bofh.it> <rUhjz-4ys-3@gated-at.bofh.it> <rU6xR-5Z5-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Krzysztof,

On 07/12/2016 11:08 PM, Krzysztof Kozlowski wrote:
> The commit 97f659a2e972 ("mmc: dw_mmc: prevent to set the wrong
> value") reordered the code so the 'uhs' variable used in
> mmc_regulator_set_vqmmc() error message is always 0 at that time thus
> always printing 3.3 voltage.  Instead use value obtained from ios in
> printed error message.

The commit 97f659a2e972 was dropped because some board didn't work fine.
Some boards didn't use the vqmmc suppy and not defined into device-tree.

It's short time to fix. I will re-send the patch on next.
At that time, i will check this patch.

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  drivers/mmc/host/dw_mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index c2a128628b31..7de561065003 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1416,8 +1416,8 @@ static int dw_mci_switch_voltage(struct mmc_host *mmc, struct mmc_ios *ios)
>  	ret = mmc_regulator_set_vqmmc(mmc, ios);
>  	if (ret) {
>  		dev_err(&mmc->class_dev,
> -				 "Regulator set error %d - %s V\n",
> -				 ret, uhs & v18 ? "1.8" : "3.3");
> +				 "Regulator set error %d - %s\n",
> +				 ret, mmc_voltage_to_str(ios));
>  		return ret;
>  	}
>  
>

Thread

[PATCH 2/2] mmc: dw_mmc: Print proper voltage on error Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-12 16:10 +0200
  Re: [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error Jaehoon Chung <jh80.chung@samsung.com> - 2016-07-13 03:40 +0200
    Re: [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-13 10:00 +0200

csiph-web