Groups > linux.kernel > #1442034

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

From	Kalle Valo <kvalo@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded
Date	2016-07-13 09:00 +0200
Message-ID	<rUmjf-7Re-3@gated-at.bofh.it> (permalink)
References	<rTLa2-hv-11@gated-at.bofh.it> <rTNOx-29b-9@gated-at.bofh.it> <rTNYe-2cE-27@gated-at.bofh.it> <rTO7T-2fM-3@gated-at.bofh.it> <rTQ9I-3wF-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Prarit Bhargava <prarit@redhat.com> writes:

>> We implement thermal zone because we do support it, but the problem is
>> that we need the firmware to be loaded for that. So you can argue that
>> we should register *later* when the firmware is loaded. But this is
>> really not helping all that much because the firmware can also be
>> stopped at any time. So you'd want us to register / unregister the
>> thermal zone anytime the firmware is loaded / unloaded?
>
> You might have to do that.  I think that if the firmware enables a feature then
> the act of loading the firmware should run the code that enables the feature.
> IMO of course.

But I suspect that the iwlwifi firmware is loaded during interface up
(and unloaded during interface down) and in that case
register/unregister would be happening all the time. That doesn't sound
like a good idea. I would rather try to fix the thermal interface to
handle the cases when the measurement is not available.

-- 
Kalle Valo

Thread

[PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-11 17:20 +0200
  Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded "Coelho, Luciano" <luciano.coelho@intel.com> - 2016-07-11 18:10 +0200
    Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-11 19:10 +0200
  Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Emmanuel Grumbach <egrumbach@gmail.com> - 2016-07-11 20:10 +0200
    Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-11 20:20 +0200
      Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2016-07-11 20:30 +0200
        Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-11 22:40 +0200
          Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Kalle Valo <kvalo@codeaurora.org> - 2016-07-13 09:00 +0200
            Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Luca Coelho <luca@coelho.fi> - 2016-07-13 09:30 +0200
              Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-13 12:30 +0200
                Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Kalle Valo <kvalo@codeaurora.org> - 2016-07-14 10:10 +0200
                RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2016-07-14 11:10 +0200
            Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-13 12:10 +0200
              Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Kalle Valo <kvalo@codeaurora.org> - 2016-07-14 09:20 +0200
        Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Stanislaw Gruszka <sgruszka@redhat.com> - 2016-07-14 11:30 +0200
          RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2016-07-14 11:50 +0200
            Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Stanislaw Gruszka <sgruszka@redhat.com> - 2016-07-15 13:30 +0200
              Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-15 14:20 +0200
                RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2016-07-17 08:20 +0200

csiph-web