Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440738

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Show all headers | View raw

On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote:
> Didn't get any feedback or review comments on this patch.  Resending
> ...
> 
> P.

Sorry, this got flooded down my inbox.


> ---8<---
> 
> The iwlwifi driver implements a thermal zone and hwmon device, but
> returns -EIO on temperature reads if the firmware isn't loaded.  This
> results in the error
> 
> iwlwifi-virtual-0
> Adapter: Virtual device
> ERROR: Can't get value of subfeature temp1_input: I/O error
> temp1:            N/A
> 
> being output when using sensors from the lm-sensors package.  Since
> the temperature cannot be read unless the ucode is loaded there is no
> reason to add the interface only to have it return an error 100% of
> the time.
> 
> This patch moves the firmware check to
> iwl_mvm_thermal_zone_register() and
> stops the thermal zone from being created if the ucode hasn't been
> loaded.
> 
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> Cc: Johannes Berg <johannes.berg@intel.com>
> Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> Cc: Luca Coelho <luciano.coelho@intel.com>
> Cc: Intel Linux Wireless <linuxwifi@intel.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: Chaya Rachel Ivgi <chaya.rachel.ivgi@intel.com>
> Cc: Sara Sharon <sara.sharon@intel.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> ---

I have now sent it for review on our internal tree.

--
Luca.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-11 17:20 +0200
  Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded "Coelho, Luciano" <luciano.coelho@intel.com> - 2016-07-11 18:10 +0200
    Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-11 19:10 +0200
  Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Emmanuel Grumbach <egrumbach@gmail.com> - 2016-07-11 20:10 +0200
    Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-11 20:20 +0200
      Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2016-07-11 20:30 +0200
        Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-11 22:40 +0200
          Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Kalle Valo <kvalo@codeaurora.org> - 2016-07-13 09:00 +0200
            Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Luca Coelho <luca@coelho.fi> - 2016-07-13 09:30 +0200
              Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-13 12:30 +0200
                Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Kalle Valo <kvalo@codeaurora.org> - 2016-07-14 10:10 +0200
                RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2016-07-14 11:10 +0200
            Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-13 12:10 +0200
              Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Kalle Valo <kvalo@codeaurora.org> - 2016-07-14 09:20 +0200
        Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Stanislaw Gruszka <sgruszka@redhat.com> - 2016-07-14 11:30 +0200
          RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2016-07-14 11:50 +0200
            Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Stanislaw Gruszka <sgruszka@redhat.com> - 2016-07-15 13:30 +0200
              Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded Prarit Bhargava <prarit@redhat.com> - 2016-07-15 14:20 +0200
                RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless  ucode is loaded "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2016-07-17 08:20 +0200

csiph-web