Re: [PATCH] device-tree: aqp8064.dtsi: Remove usb phy dr_mode = "host"

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Bjorn Andersson <bjorn.andersson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] device-tree: aqp8064.dtsi: Remove usb phy dr_mode = "host"
Date	Wed, 13 Jul 2016 00:50:03 +0200
Message-ID	<rUeF5-2Ns-73@gated-at.bofh.it> (permalink)
References	<rUeF5-2Ns-65@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=H/wR5BI6MlQGU0MmdlpS4gJCE0MDFLymVdvPX5K4VTU=; b=gb247N3OPwvtorq05nEehsupsbYsAgmO0VCDlRQy5Cafi7tZlD9uNfmU9mNZsia42Q 8/KPWhLrGou668Zlj+DLmUZXNb1YunlB5wuDNx7+xkXWLRfTeOXEizfGrJ8MUKlUEliV kKk1GmCZwM1+FLxJ3dtnZG48OhZIYhRNytmEk=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=H/wR5BI6MlQGU0MmdlpS4gJCE0MDFLymVdvPX5K4VTU=; b=b5pvdHyCI1HyS5sFXMHqaBQQF9BrnGgMLW1StWfmBUJzlM6B7W9sXaiXedLMmMawxH JSqmsmjRf040jYVCZkWIEAdWwmM6AJnQ2MNBfcwbjSrmG2tdwfhmdii4auJDN3hj8Lmk /wQXsPGBRnsBsPN/l2hi+jprhQq7zXXACNatvNUS9mHkKcNhGZJiwUYJ/nWczdGdW/Ge umENjDrTBEzQGbYF+NyVrx98PKR2FW9sBEq2NIQ1zn/CHQeqvw0+bgRegRDjBjEoMsML 6wYR9z9AXi14+yPnwpBOp6NRa44tWIlIgyHykFP+4WUJtoSQlWNw/KilFp39aT2vyEkm SMHw==
X-Gm-Message-State	ALyK8tLnB5Lb68LHhMsLgFziLpXYuBQKN5jwEvA3fI8jYyS0e8XRi1Nl/7fx4p5ucvTDur0P
X-Received	by 10.66.235.227 with SMTP id up3mr8104584pac.32.1468363494955; Tue, 12 Jul 2016 15:44:54 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	lkml <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@codeaurora.org>, Stephen Boyd <stephen.boyd@linaro.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
X-Original-Date	Tue, 12 Jul 2016 15:44:52 -0700
X-Original-Message-ID	<20160712224452.GH23833@tuxbot>
X-Original-References	<1468363195-11730-1-git-send-email-john.stultz@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1441849

Show key headers only | View raw

On Tue 12 Jul 15:39 PDT 2016, John Stultz wrote:

> Most 8064 devices have micro-usb ports for phy1, so setting
> the dr_mode to host here seems incorrect.
> 
> Leaving it unspecified should default to otg, and then
> any boards that wish to specify something else, can
> override it in their dts file.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Andy Gross <agross@codeaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Cc: Stephen Boyd <stephen.boyd@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-apq8064.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index df96ccd..cc816d4 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -705,7 +705,6 @@
>  			reg		= <0x12500000 0x400>;
>  			interrupts	= <GIC_SPI 100 IRQ_TYPE_NONE>;
>  			status		= "disabled";
> -			dr_mode		= "host";
>  
>  			clocks		= <&gcc USB_HS1_XCVR_CLK>,
>  					  <&gcc USB_HS1_H_CLK>;
> -- 
> 1.9.1
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] device-tree: aqp8064.dtsi: Remove usb phy dr_mode = "host" John Stultz <john.stultz@linaro.org> - 2016-07-13 00:50 +0200
  Re: [PATCH] device-tree: aqp8064.dtsi: Remove usb phy dr_mode =  "host" Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-07-13 00:50 +0200

csiph-web