Re: [PATCH] device-tree: aqp8064.dtsi: Remove usb phy dr_mode = "host"

From	Bjorn Andersson <bjorn.andersson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] device-tree: aqp8064.dtsi: Remove usb phy dr_mode = "host"
Date	2016-07-13 00:50 +0200
Message-ID	<rUeF5-2Ns-73@gated-at.bofh.it> (permalink)
References	<rUeF5-2Ns-65@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 12 Jul 15:39 PDT 2016, John Stultz wrote:

> Most 8064 devices have micro-usb ports for phy1, so setting
> the dr_mode to host here seems incorrect.
> 
> Leaving it unspecified should default to otg, and then
> any boards that wish to specify something else, can
> override it in their dts file.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Andy Gross <agross@codeaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Cc: Stephen Boyd <stephen.boyd@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-apq8064.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index df96ccd..cc816d4 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -705,7 +705,6 @@
>  			reg		= <0x12500000 0x400>;
>  			interrupts	= <GIC_SPI 100 IRQ_TYPE_NONE>;
>  			status		= "disabled";
> -			dr_mode		= "host";
>  
>  			clocks		= <&gcc USB_HS1_XCVR_CLK>,
>  					  <&gcc USB_HS1_H_CLK>;
> -- 
> 1.9.1
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] device-tree: aqp8064.dtsi: Remove usb phy dr_mode = "host" John Stultz <john.stultz@linaro.org> - 2016-07-13 00:50 +0200
  Re: [PATCH] device-tree: aqp8064.dtsi: Remove usb phy dr_mode =  "host" Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-07-13 00:50 +0200

csiph-web