Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1443620

Re: [RT PATCH 2/2] timers: wakeup all timer waiters without holding the base lock

Show all headers | View raw

On Thu, 14 Jul 2016 19:19:47 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:

> On 07/14/2016 06:09 PM, Steven Rostedt wrote:
> > On Thu, 14 Jul 2016 18:05:04 +0200
> > Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> >   
> >> There should be no need to hold the base lock during the wakeup. There
> >> should be no boosting involved, the wakeup list has its own lock so it
> >> should be safe to do this without the lock.
> >>
> >> Cc: stable-rt@vger.kernel.org  
> > 
> > Nothing against this patch, but as you marked it for stable, can you
> > add to the change log what issue you had that caused you to make this
> > change?  
> 
> #1 was noticed while looking at the code, it *might* happen.
> #2 Is not strictly required for back porting.
> I just don't see a reason for holding the lock, that is all.
> 

I have no problem backporting them. I just thought that the change log
might have been missing some useful information.

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RT PATCH 2/2] timers: wakeup all timer waiters without holding the base lock Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-07-14 18:10 +0200
  Re: [RT PATCH 2/2] timers: wakeup all timer waiters without holding  the base lock Steven Rostedt <rostedt@goodmis.org> - 2016-07-14 18:20 +0200
    Re: [RT PATCH 2/2] timers: wakeup all timer waiters without holding  the base lock Steven Rostedt <rostedt@goodmis.org> - 2016-07-14 19:30 +0200
    Re: [RT PATCH 2/2] timers: wakeup all timer waiters without holding  the base lock Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-07-14 19:30 +0200

csiph-web