Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1443560

[RT PATCH 2/2] timers: wakeup all timer waiters without holding the base lock

From Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Newsgroups linux.kernel
Subject [RT PATCH 2/2] timers: wakeup all timer waiters without holding the base lock
Date 2016-07-14 18:10 +0200
Message-ID <rURn4-3qz-29@gated-at.bofh.it> (permalink)
References <rURn4-3qz-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


There should be no need to hold the base lock during the wakeup. There
should be no boosting involved, the wakeup list has its own lock so it
should be safe to do this without the lock.

Cc: stable-rt@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 kernel/time/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index b3c3d3a6216f..716ef84a5d87 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -1313,8 +1313,8 @@ static inline void __run_timers(struct tvec_base *base)
 			}
 		}
 	}
-	wakeup_timer_waiters(base);
 	spin_unlock_irq(&base->lock);
+	wakeup_timer_waiters(base);
 }
 
 #ifdef CONFIG_NO_HZ_COMMON
-- 
2.8.1

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[RT PATCH 2/2] timers: wakeup all timer waiters without holding the base lock Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-07-14 18:10 +0200
  Re: [RT PATCH 2/2] timers: wakeup all timer waiters without holding  the base lock Steven Rostedt <rostedt@goodmis.org> - 2016-07-14 18:20 +0200
    Re: [RT PATCH 2/2] timers: wakeup all timer waiters without holding  the base lock Steven Rostedt <rostedt@goodmis.org> - 2016-07-14 19:30 +0200
    Re: [RT PATCH 2/2] timers: wakeup all timer waiters without holding  the base lock Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-07-14 19:30 +0200

csiph-web