Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1442926

Re: [PATCH] uapi: move forward declarations of internal structures

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Alexey Dobriyan <adobriyan@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] uapi: move forward declarations of internal structures
Date Thu, 14 Jul 2016 00:50:01 +0200
Message-ID <rUB8B-WN-7@gated-at.bofh.it> (permalink)
References <rUAmi-nH-9@gated-at.bofh.it> <rUAFz-Ll-15@gated-at.bofh.it>
X-Original-To Andrew Morton <akpm@linux-foundation.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZQdOy16ueroQFjjUMuFcfLe8/HMWGOUPqP+TYpXcGtU=; b=W6eDns2na1CuNxQVkOZMSf9polDV9oIwzjVFNeSOkE+12OhvIvk0AtbauY/zHoSL+0 zahR3/0IVLsDA13qnWdTbnucPG1UKMNb7ozksumPGkk2j70+aVzNzEZaqlfu75jNeuei iacuGLNegmENr4aS9s+HPx8k4Zl6GXCCBqg97s06uKtmjZt3uMG/rxk5hp2p0TJC86v3 /iZLyK0ikqUjwSp9Io5+w+RI8ip7U6dB+JQdbHCK9M9FVe9zbvNiWdDbyilAjl4KJZZp GmrnMxRjNowBjqQl4C5l62oGAGjHllTEEeV69XgE3tcbGB5r+8uzkMYcz63QmcTh/+SR /6VQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZQdOy16ueroQFjjUMuFcfLe8/HMWGOUPqP+TYpXcGtU=; b=FWi/7Oj/RKDAZdcRTd8vFS117UEKSZL0E2rvLUlQxkxr4UumydfAInMQD1lZ2ADhhD XrlvBqpWz2Kru+7hFMcVEzXfvTlLeNrNyYbAnY0MDkG60lH+R+UTpp79zmXHIaG54ZHn DGkS33baBF1RF+NuVj20PWk2tFbh0qUx7WrU78MrtqtjM4R7knjlgNglLtQj9/2U0JRi vNhDx1CI+JiX+lyIFpqZ7I8CWMyTF/yydcA193NpUQH+43kPPjsbG5MF3vIGe2Aprio5 UoB/Ty6wSp8T/3JbxzQdvVpai5/1mYmqewl1kXrRcSO32h2YPXsyEo3+RQ08M8JZiF9Z 58JQ==
X-Gm-Message-State ALyK8tKaurl4nat7PZUAO4l2WoJ7OwrBsbhk7XXE1998acr4eFjlp7mHldFQGReOavgOjA==
X-Received by 10.25.4.8 with SMTP id 8mr5006720lfe.221.1468449863588; Wed, 13 Jul 2016 15:44:23 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.24 (2015-08-30)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 16
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org
X-Original-Date Thu, 14 Jul 2016 01:44:20 +0300
X-Original-Message-ID <20160713224420.GA15618@p183.telecom.by>
X-Original-References <20160713215808.GA22486@p183.telecom.by> <20160713151557.a87f48b707f628c7cc5c6505@linux-foundation.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1442926

Show key headers only | View raw


On Wed, Jul 13, 2016 at 03:15:57PM -0700, Andrew Morton wrote:
> On Thu, 14 Jul 2016 00:58:08 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> 
> > Move "struct completion;".
> > Move "struct task_struct;".
> 
> That tells us no more than does the diff.
> 
> What's the reason for this change?  Any perceptible benefit?

You're right.

Changelog should be

Don't user forward declarations of internal kernel structures
in headers exported to userspace.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] uapi: move forward declarations of internal structures Alexey Dobriyan <adobriyan@gmail.com> - 2016-07-14 00:00 +0200
  Re: [PATCH] uapi: move forward declarations of internal structures Andrew Morton <akpm@linux-foundation.org> - 2016-07-14 00:20 +0200
    Re: [PATCH] uapi: move forward declarations of internal structures Alexey Dobriyan <adobriyan@gmail.com> - 2016-07-14 00:50 +0200

csiph-web