Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1442890 > unrolled thread

[PATCH] uapi: move forward declarations of internal structures

Back to article view | Back to linux.kernel

Contents

  [PATCH] uapi: move forward declarations of internal structures Alexey Dobriyan <adobriyan@gmail.com> - 2016-07-14 00:00 +0200
    Re: [PATCH] uapi: move forward declarations of internal structures Andrew Morton <akpm@linux-foundation.org> - 2016-07-14 00:20 +0200
      Re: [PATCH] uapi: move forward declarations of internal structures Alexey Dobriyan <adobriyan@gmail.com> - 2016-07-14 00:50 +0200

#1442890 — [PATCH] uapi: move forward declarations of internal structures

Move "struct completion;".
Move "struct task_struct;".

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 include/linux/capability.h      |    1 +
 include/linux/sysctl.h          |    1 +
 include/uapi/linux/capability.h |    2 --
 include/uapi/linux/sysctl.h     |    2 --
 4 files changed, 2 insertions(+), 4 deletions(-)

--- a/include/linux/capability.h
+++ b/include/linux/capability.h
@@ -38,6 +38,7 @@ struct cpu_vfs_cap_data {
 struct file;
 struct inode;
 struct dentry;
+struct task_struct;
 struct user_namespace;
 
 extern const kernel_cap_t __cap_empty_set;
--- a/include/linux/sysctl.h
+++ b/include/linux/sysctl.h
@@ -28,6 +28,7 @@
 #include <uapi/linux/sysctl.h>
 
 /* For the /proc/sys support */
+struct completion;
 struct ctl_table;
 struct nsproxy;
 struct ctl_table_root;
--- a/include/uapi/linux/capability.h
+++ b/include/uapi/linux/capability.h
@@ -15,8 +15,6 @@
 
 #include <linux/types.h>
 
-struct task_struct;
-
 /* User-level do most of the mapping between kernel and user
    capabilities based on the version tag given by the kernel. The
    kernel might be somewhat backwards compatible, but don't bet on
--- a/include/uapi/linux/sysctl.h
+++ b/include/uapi/linux/sysctl.h
@@ -26,8 +26,6 @@
 #include <linux/types.h>
 #include <linux/compiler.h>
 
-struct completion;
-
 #define CTL_MAXNAME 10		/* how many path components do we allow in a
 				   call to sysctl?   In other words, what is
 				   the largest acceptable value for the nlen

[toc] | [next] | [standalone]

#1442913

On Thu, 14 Jul 2016 00:58:08 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:

> Move "struct completion;".
> Move "struct task_struct;".

That tells us no more than does the diff.

What's the reason for this change?  Any perceptible benefit?

[toc] | [prev] | [next] | [standalone]

#1442926

On Wed, Jul 13, 2016 at 03:15:57PM -0700, Andrew Morton wrote:
> On Thu, 14 Jul 2016 00:58:08 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> 
> > Move "struct completion;".
> > Move "struct task_struct;".
> 
> That tells us no more than does the diff.
> 
> What's the reason for this change?  Any perceptible benefit?

You're right.

Changelog should be

Don't user forward declarations of internal kernel structures
in headers exported to userspace.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web