Re: [PATCH] drivers/mtd/chips/cfi_cmdset_0020.c: Deinline do_write_buffer, save 5316 bytes

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers/mtd/chips/cfi_cmdset_0020.c: Deinline do_write_buffer, save 5316 bytes
Date	2016-07-10 04:00 +0200
Message-ID	<rTcch-2h0-3@gated-at.bofh.it> (permalink)
References	<rlJu2-86Z-11@gated-at.bofh.it> <rlJu2-86Z-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 08, 2016 at 08:35:43PM +0200, Denys Vlasenko wrote:
> This function compiles to 2554 bytes of machine code.
> In C, the function is almost 200 lines long.
> 
> It has only one callsite, but forced inlining that much code
> makes gcc generate significantly worse code. Let gcc itself decide
> what to do.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: David Woodhouse <David.Woodhouse@intel.com>
> CC: Brian Norris <computersforpeace@gmail.com>
> CC: Dan Carpenter <dan.carpenter@oracle.com>
> CC: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> CC: linux-mtd@lists.infradead.org
> CC: linux-kernel@vger.kernel.org

Applied to l2-mtd.git

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] drivers/mtd/chips/cfi_cmdset_0020.c: Deinline  do_write_buffer, save 5316 bytes Brian Norris <computersforpeace@gmail.com> - 2016-07-10 04:00 +0200

csiph-web