Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1438694
| Path | csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!border2.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | "Jan Beulich" <JBeulich@suse.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group" |
| Date | Thu, 07 Jul 2016 18:00:02 +0200 |
| Message-ID | <rSjSy-vy-27@gated-at.bofh.it> (permalink) |
| References | <rScem-3Vx-27@gated-at.bofh.it> <rSe6u-59g-7@gated-at.bofh.it> <rSeg9-5cz-21@gated-at.bofh.it> <rSjzc-nu-27@gated-at.bofh.it> |
| X-Original-To | "Andrew Cooper" <andrew.cooper3@citrix.com>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com> |
| X-Mailer | Novell GroupWise Internet Agent 14.2.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Content-Transfer-Encoding | 8bit |
| Content-Disposition | inline |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 26 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | "Roger Pau Monne" <roger.pau@citrix.com>, <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org> |
| X-Original-Date | Thu, 07 Jul 2016 09:57:10 -0600 |
| X-Original-Message-ID | <577E97F602000078000FC546@prv-mh.provo.novell.com> |
| X-Original-References | <577E233202000078000FBE11@prv-mh.provo.novell.com> <20160707094535.wsgrxlnib5ajcsdc@mac> <7732540a-aa37-9e33-e805-838dc4c43676@citrix.com> <20160707153750.GB11480@localhost.localdomain> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1438694 |
Show key headers only | View raw
>>> On 07.07.16 at 17:37, <konrad.wilk@oracle.com> wrote: > On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote: >> On 07/07/16 10:45, Roger Pau Monne wrote: >> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: >> >> The functions such get passed to have been taking pointers to const >> >> since at least 2.6.16. >> >> >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com> >> > Acked-by: Roger Pau Monné <roger.pau@citrix.com> >> > >> > Although the wording in the commit message looks weird to me, but I'm not a > >> > native speaker anyway. >> >> As a native speaker, I can't parse it either. >> >> I think s/such/these/ is needed. > > The functions such as these have been taking pointers to const > since at least 2.6.16. I had taken Andrew's suggestion literally and changed it to "The functions these get passed to have been taking pointers to const since at least 2.6.16" for a possible (if needed) resubmission. Jan
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] xen-blkback: constify instance of "struct attribute_group" "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 09:50 +0200
Re: [PATCH] xen-blkback: constify instance of "struct attribute_group" Roger Pau Monne <roger.pau@citrix.com> - 2016-07-07 11:50 +0200
Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group" Andrew Cooper <andrew.cooper3@citrix.com> - 2016-07-07 12:00 +0200
Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group" Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-07-07 17:40 +0200
Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group" "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 18:00 +0200
Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group" Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-07-08 16:00 +0200
csiph-web