Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible

From	"Jan Beulich" <JBeulich@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible
Date	2016-07-07 12:10 +0200
Message-ID	<rSepQ-5v6-31@gated-at.bofh.it> (permalink)
References	<rScxJ-4ic-77@gated-at.bofh.it> <rSe6u-59g-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>>> On 07.07.16 at 11:44, <roger.pau@citrix.com> wrote:
> On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote:
>> ... as being the simpler variant.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>>  drivers/block/xen-blkfront.c |    7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>> 
>> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c
>> +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c
>> @@ -1825,14 +1825,13 @@ again:
>>  		}
>>  		kfree(path);
>>  	}
>> -	err = xenbus_printf(xbt, dev->nodename, "protocol", "%s",
>> -			    XEN_IO_PROTO_ABI_NATIVE);
>> +	err = xenbus_write(xbt, dev->nodename, "protocol",
>> +			   XEN_IO_PROTO_ABI_NATIVE);
>>  	if (err) {
>>  		message = "writing protocol";
>>  		goto abort_transaction;
>>  	}
>> -	err = xenbus_printf(xbt, dev->nodename,
>> -			    "feature-persistent", "%u", 1);
>> +	err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1");
> 
> AFAICT you forgot to replace xenbus_printf with xenbus_write here.

Oops, indeed - thanks for noticing.

Jan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] xen-blkfront: prefer xenbus_write() over  xenbus_printf() where possible "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 10:10 +0200
  Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf()  where possible Roger Pau Monne <roger.pau@citrix.com> - 2016-07-07 11:50 +0200
    Re: [PATCH] xen-blkfront: prefer xenbus_write() over  xenbus_printf() where possible "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 12:10 +0200

csiph-web