Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1438300

[PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible

Show all headers | View raw

... as being the simpler variant.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
 drivers/block/xen-blkfront.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

--- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c
+++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c
@@ -1825,14 +1825,13 @@ again:
 		}
 		kfree(path);
 	}
-	err = xenbus_printf(xbt, dev->nodename, "protocol", "%s",
-			    XEN_IO_PROTO_ABI_NATIVE);
+	err = xenbus_write(xbt, dev->nodename, "protocol",
+			   XEN_IO_PROTO_ABI_NATIVE);
 	if (err) {
 		message = "writing protocol";
 		goto abort_transaction;
 	}
-	err = xenbus_printf(xbt, dev->nodename,
-			    "feature-persistent", "%u", 1);
+	err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1");
 	if (err)
 		dev_warn(&dev->dev,
 			 "writing persistent grants feature to xenbus");

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] xen-blkfront: prefer xenbus_write() over  xenbus_printf() where possible "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 10:10 +0200
  Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf()  where possible Roger Pau Monne <roger.pau@citrix.com> - 2016-07-07 11:50 +0200
    Re: [PATCH] xen-blkfront: prefer xenbus_write() over  xenbus_printf() where possible "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 12:10 +0200

csiph-web