[PATCH] xenbus: prefer xenbus_scanf() over xenbus_gather()

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	"Jan Beulich" <JBeulich@suse.com>
Newsgroups	linux.kernel
Subject	[PATCH] xenbus: prefer xenbus_scanf() over xenbus_gather()
Date	Thu, 07 Jul 2016 10:10:01 +0200
Message-ID	<rScxH-4ic-3@gated-at.bofh.it> (permalink)
X-Original-To	<david.vrabel@citrix.com>, <boris.ostrovsky@oracle.com>, "Juergen Gross" <JGross@suse.com>
X-Mailer	Novell GroupWise Internet Agent 14.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	8BIT
Content-Disposition	inline
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	<xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 07 Jul 2016 02:07:23 -0600
X-Original-Message-ID	<577E29DB02000078000FBF70@prv-mh.provo.novell.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1438276

Show key headers only | View raw

... for single items being collected: It is more typesafe (as the
compiler can check format string and to-be-written-to variable match)
and requires one less parameter to be passed.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
 drivers/xen/xenbus/xenbus_client.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- 4.7-rc6-prefer-xenbus_scanf.orig/drivers/xen/xenbus/xenbus_client.c
+++ 4.7-rc6-prefer-xenbus_scanf/drivers/xen/xenbus/xenbus_client.c
@@ -926,9 +926,9 @@ EXPORT_SYMBOL_GPL(xenbus_unmap_ring);
  */
 enum xenbus_state xenbus_read_driver_state(const char *path)
 {
-	enum xenbus_state result;
-	int err = xenbus_gather(XBT_NIL, path, "state", "%d", &result, NULL);
-	if (err)
+	int result;
+
+	if (xenbus_scanf(XBT_NIL, path, "state", "%d", &result) != 1)
 		result = XenbusStateUnknown;
 
 	return result;

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] xenbus: prefer xenbus_scanf() over xenbus_gather() "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 10:10 +0200

csiph-web