Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1438277

[PATCH] xen-blkback: prefer xenbus_write() over xenbus_printf() where possible

Show all headers | View raw

... as being the simpler variant.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
 drivers/block/xen-blkback/xenbus.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkback/xenbus.c
+++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkback/xenbus.c
@@ -617,9 +617,9 @@ static int xen_blkbk_probe(struct xenbus
 		goto fail;
 	}
 
-	err = xenbus_printf(XBT_NIL, dev->nodename,
-			    "feature-max-indirect-segments", "%u",
-			    MAX_INDIRECT_SEGMENTS);
+	err = xenbus_write(XBT_NIL, dev->nodename,
+			   "feature-max-indirect-segments",
+			   __stringify(MAX_INDIRECT_SEGMENTS));
 	if (err)
 		dev_warn(&dev->dev,
 			 "writing %s/feature-max-indirect-segments (%d)",
@@ -850,7 +850,7 @@ again:
 
 	xen_blkbk_barrier(xbt, be, be->blkif->vbd.flush_support);
 
-	err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "%u", 1);
+	err = xenbus_write(xbt, dev->nodename, "feature-persistent", "1");
 	if (err) {
 		xenbus_dev_fatal(dev, err, "writing %s/feature-persistent",
 				 dev->nodename);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] xen-blkback: prefer xenbus_write() over  xenbus_printf() where possible "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 10:10 +0200
  Re: [PATCH] xen-blkback: prefer xenbus_write() over xenbus_printf()  where possible Roger Pau Monne <roger.pau@citrix.com> - 2016-07-07 11:50 +0200
  Re: [Xen-devel] [PATCH] xen-blkback: prefer xenbus_write() over  xenbus_printf() where possible David Vrabel <david.vrabel@citrix.com> - 2016-07-07 12:30 +0200
    Re: [Xen-devel] [PATCH] xen-blkback: prefer xenbus_write() over  xenbus_printf() where possible David Vrabel <david.vrabel@citrix.com> - 2016-07-07 12:50 +0200

csiph-web