Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1439843

Re: [PATCH] Revert "net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings"

Show all headers | View raw

On 07/08/2016 03:54 PM, Philippe Reynes wrote:
> This reverts commit 4386f5662e63 ("net: ethernet: bcmgenet: use
> phy_ethtool_{get|set}_link_ksettings")
> 
> This patch is wrong, the function phy_ethtool_{get|set}_link_ksettings
> don't check if the device is running, but the driver bcmgenet need this
> check.
> 
> The function {get|set}_settings need to access the mdio bus, and this
> bus may only be used when the device is running. Otherwise, the clock
> is disable and a mdio access will fail.
> 
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings" Philippe Reynes <tremyfr@gmail.com> - 2016-07-09 01:00 +0200
  Re: [PATCH] Revert "net: ethernet: bcmgenet: use  phy_ethtool_{get|set}_link_ksettings" Florian Fainelli <f.fainelli@gmail.com> - 2016-07-09 01:10 +0200
  Re: [PATCH] Revert "net: ethernet: bcmgenet: use  phy_ethtool_{get|set}_link_ksettings" David Miller <davem@davemloft.net> - 2016-07-11 22:00 +0200

csiph-web