Re: [PATCH] Revert "net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings"

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Revert "net: ethernet: bcmgenet: use phy_ethtool_{get\|set}_link_ksettings"
Date	2016-07-11 22:00 +0200
Message-ID	<rTPwZ-33Z-1@gated-at.bofh.it> (permalink)
References	<rSMUy-2Ij-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Philippe Reynes <tremyfr@gmail.com>
Date: Sat,  9 Jul 2016 00:54:47 +0200

> This reverts commit 4386f5662e63 ("net: ethernet: bcmgenet: use
> phy_ethtool_{get|set}_link_ksettings")
> 
> This patch is wrong, the function phy_ethtool_{get|set}_link_ksettings
> don't check if the device is running, but the driver bcmgenet need this
> check.
> 
> The function {get|set}_settings need to access the mdio bus, and this
> bus may only be used when the device is running. Otherwise, the clock
> is disable and a mdio access will fail.
> 
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>

Applied.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] Revert "net: ethernet: bcmgenet: use  phy_ethtool_{get|set}_link_ksettings" David Miller <davem@davemloft.net> - 2016-07-11 22:00 +0200

csiph-web