Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX
Date	2016-07-08 13:10 +0200
Message-ID	<rSBPs-3Z6-35@gated-at.bofh.it> (permalink)
References	(5 earlier) <rShnI-7n8-21@gated-at.bofh.it> <rSk2d-Ok-25@gated-at.bofh.it> <rSklz-X0-7@gated-at.bofh.it> <rSkYh-1pg-1@gated-at.bofh.it> <rSlB0-1Eu-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 07, 2016 at 02:43:49PM -0300, Eduardo Habkost wrote:
> I see. If you have an useful use case for it, we may consider
> that. But first I would like to see an actual case where a
> feature was not added to GET_SUPPORTED_CPUID yet, but would not
> crash and burn if forcibly enabled by QEMU.

Ok.

> I mean live migration to a different host (that normally has the
> same CPU vendor). When you live-migrate or use savevm, you need
> to send the machine state to the other host. This is implemented
> using VMStateDescription structs describing the data to be
> migrated. See vmstate_x86_cpu in target-i386/machine.c, for
> example.
> 
> You need additional migration sections if the feature introduces
> additional state (e.g. CPU registers) that need to be migrated
> too, to keep the feature working. If there's new state but no
> migration support is implemented yet, you need to add the feature
> to unmigratable_flags.
> 
> For an example where no additional state is introduced by new
> features, see:

Thanks for the examples and the explanation - I see the deal now.

Ok, I'll go through the features and see what kind of state the kernel
programs in there and add them to a VMStateDescription thing. Hohumm,
makes sense to me.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Thread

[PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Paolo Bonzini <pbonzini@redhat.com> - 2016-07-06 15:50 +0200
  Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Borislav Petkov <bp@alien8.de> - 2016-07-06 16:20 +0200
    Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Paolo Bonzini <pbonzini@redhat.com> - 2016-07-06 16:30 +0200
      Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Borislav Petkov <bp@alien8.de> - 2016-07-07 12:50 +0200
        Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Paolo Bonzini <pbonzini@redhat.com> - 2016-07-07 13:10 +0200
          Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Borislav Petkov <bp@alien8.de> - 2016-07-07 13:50 +0200
            Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Paolo Bonzini <pbonzini@redhat.com> - 2016-07-07 14:30 +0200
              Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Borislav Petkov <bp@alien8.de> - 2016-07-07 15:00 +0200
                Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Paolo Bonzini <pbonzini@redhat.com> - 2016-07-07 15:20 +0200
                Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Borislav Petkov <bp@alien8.de> - 2016-07-07 18:10 +0200
                Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Paolo Bonzini <pbonzini@redhat.com> - 2016-07-07 18:20 +0200
                Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Eduardo Habkost <ehabkost@redhat.com> - 2016-07-07 18:30 +0200
                Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Borislav Petkov <bp@alien8.de> - 2016-07-07 19:10 +0200
                Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Eduardo Habkost <ehabkost@redhat.com> - 2016-07-07 19:50 +0200
                Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Borislav Petkov <bp@alien8.de> - 2016-07-08 13:10 +0200
                Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Paolo Bonzini <pbonzini@redhat.com> - 2016-07-08 13:20 +0200
                Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX Borislav Petkov <bp@alien8.de> - 2016-07-08 15:00 +0200
  Re: [PATCH] KVM: SVM: fix trashing of MSR_TSC_AUX kbuild test robot <lkp@intel.com> - 2016-07-06 17:10 +0200

csiph-web