Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

From	Thomas Graf <tgraf@suug.ch>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable
Date	2016-07-08 13:10 +0200
Message-ID	<rSBPs-3Z6-25@gated-at.bofh.it> (permalink)
References	(4 earlier) <rnTyX-5JF-39@gated-at.bofh.it> <robma-36m-15@gated-at.bofh.it> <rodnY-4BO-5@gated-at.bofh.it> <rSdtM-4Uf-29@gated-at.bofh.it> <rSofv-3qc-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/07/16 at 10:36pm, Jiri Kosina wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index f45929c..630838e 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -52,6 +52,7 @@
>  #include <uapi/linux/netdevice.h>
>  #include <uapi/linux/if_bonding.h>
>  #include <uapi/linux/pkt_cls.h>
> +#include <linux/hashtable.h>
>  
>  struct netpoll_info;
>  struct device;
> @@ -1778,6 +1779,7 @@ struct net_device {
>  	unsigned int		num_tx_queues;
>  	unsigned int		real_num_tx_queues;
>  	struct Qdisc		*qdisc;
> +	DECLARE_HASHTABLE	(qdisc_hash, 16);

This blows up net_device to an insane size: 64K * sizeof(struct
hlist_head). Can we allocate this on demand for net_devices where
it is actually needed? The majority of virtual devices won't need
this. Doesn't have to be rhashtable, can still be fixed size but
at least allocate it.

Thread

[RFC PATCH] net: sched: convert qdisc linked list to hashtable (was  Re: Deleting child qdisc doesn't reset parent to default qdisc?) Jiri Kosina <jikos@kernel.org> - 2016-07-07 11:10 +0200
  Re: [RFC PATCH] net: sched: convert qdisc linked list to hashtable  (was Re: Deleting child qdisc doesn't reset parent to default qdisc?) Eric Dumazet <eric.dumazet@gmail.com> - 2016-07-07 16:00 +0200
    Re: [RFC PATCH] net: sched: convert qdisc linked list to hashtable  (was Re: Deleting child qdisc doesn't reset parent to default qdisc?) Jiri Kosina <jikos@kernel.org> - 2016-07-07 18:40 +0200
      Re: [RFC PATCH] net: sched: convert qdisc linked list to hashtable  (was Re: Deleting child qdisc doesn't reset parent to default qdisc?) Eric Dumazet <eric.dumazet@gmail.com> - 2016-07-07 19:00 +0200
  [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable Jiri Kosina <jikos@kernel.org> - 2016-07-07 22:40 +0200
    Re: [RFC PATCH v2] net: sched: convert qdisc linked list to  hashtable Eric Dumazet <eric.dumazet@gmail.com> - 2016-07-08 11:00 +0200
      Re: [RFC PATCH v2] net: sched: convert qdisc linked list to  hashtable Jiri Kosina <jikos@kernel.org> - 2016-07-08 11:10 +0200
    Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable Thomas Graf <tgraf@suug.ch> - 2016-07-08 13:10 +0200
      Re: [RFC PATCH v2] net: sched: convert qdisc linked list to  hashtable Eric Dumazet <eric.dumazet@gmail.com> - 2016-07-08 16:00 +0200

csiph-web