Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436995

Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback

From Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback
Date 2016-07-05 15:20 +0200
Message-ID <rRyqC-3hh-49@gated-at.bofh.it> (permalink)
References <rQcBP-2e6-5@gated-at.bofh.it> <rRyqC-3hh-51@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hello Kalle,

On 07/05/2016 09:09 AM, Kalle Valo wrote:
> Javier Martinez Canillas <javier@osg.samsung.com> writes:
> 
>> The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added
>> interface") attempted to fix an issue when a new AP interface is added.
>>
>> But the patch didn't check the return value of the functions doing the
>> firmware calls and returned an error even if the functions didn't fail.
>>
>> This prevents the network device to be registered properly, so fix it.
>>
>> Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added interface")
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> The fixes line should be:
> 
> Fixes: 7311ea850079 ("mwifiex: fix AP start problem for newly added interface")
> 
> I can fix that before I apply the patch.
> 

Sigh, it was a copy and paste error when I copied the SHA-1 from the
commit message. Sorry about that and thanks for taking care of this.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-01 21:50 +0200
  Re: [PATCH] mwifiex: fix unconditional error return in  .add_virtual_intf callback Julian Calaby <julian.calaby@gmail.com> - 2016-07-04 02:20 +0200
  Re: [PATCH] mwifiex: fix unconditional error return in  .add_virtual_intf callback Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-05 15:20 +0200
  Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback Kalle Valo <kvalo@codeaurora.org> - 2016-07-05 15:20 +0200
  Re: mwifiex: fix unconditional error return in .add_virtual_intf  callback Kalle Valo <kvalo@codeaurora.org> - 2016-07-05 15:30 +0200

csiph-web