Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436088

Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback

Show all headers | View raw

Hi All,

On Sat, Jul 2, 2016 at 5:39 AM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added
> interface") attempted to fix an issue when a new AP interface is added.
>
> But the patch didn't check the return value of the functions doing the
> firmware calls and returned an error even if the functions didn't fail.
>
> This prevents the network device to be registered properly, so fix it.
>
> Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added interface")
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Looks correct to me as Dan Carpenter submitted the same fix.

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-01 21:50 +0200
  Re: [PATCH] mwifiex: fix unconditional error return in  .add_virtual_intf callback Julian Calaby <julian.calaby@gmail.com> - 2016-07-04 02:20 +0200
  Re: [PATCH] mwifiex: fix unconditional error return in  .add_virtual_intf callback Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-05 15:20 +0200
  Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback Kalle Valo <kvalo@codeaurora.org> - 2016-07-05 15:20 +0200
  Re: mwifiex: fix unconditional error return in .add_virtual_intf  callback Kalle Valo <kvalo@codeaurora.org> - 2016-07-05 15:30 +0200

csiph-web