Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437027

Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular

Show all headers | View raw

[Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular] On 05/07/2016 (Tue 11:04) Krzysztof Kozlowski wrote:

> On 07/04/2016 11:12 PM, Paul Gortmaker wrote:
> > The Kconfig currently controlling compilation of this code is:
> > 
> > arch/arm/mach-exynos/Kconfig:menuconfig ARCH_EXYNOS
> > arch/arm/mach-exynos/Kconfig:   bool "Samsung EXYNOS" if ARCH_MULTI_V7
> > 
> > ...meaning that it currently is not being built as a module by anyone.
> > 
> > Lets remove the couple traces of modularity so that when reading the
> > driver there is no doubt it is builtin-only.
> > 
> > Lets remove the modular code that is essentially orphaned, so that
> > when reading the driver there is no doubt it is builtin-only.
> > 

[...]

> > -MODULE_DESCRIPTION("Exynos Audio Subsystem Clock Controller");
> > -MODULE_LICENSE("GPL v2");
> > -MODULE_ALIAS("platform:exynos-audss-clk");
> 
> Why not removing .remove() callback as well?
> 
> I don't find sysfs unbind hook useful except testing the exit paths...
> which in that case do not exist anymore (there is no "modprobe -r" for
> it anyway).

Yes, I normally delete the .remove callbacks as indicated in the 0/10,
but somehow I overlooked this one.   Thanks for spotting it.  I'll
delete it and disable the sysfs bind in v2.

Paul.
--

> 
> Best regards,
> Krzysztof
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] clk: fix/remove module usage in non-modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
  [PATCH 03/10] clk: mvebu: make cp110-system-controller explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
  [PATCH 02/10] clk: meson: make gxbb explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
    Re: [PATCH 02/10] clk: meson: make gxbb explicitly non-modular Michael Turquette <mturquette@baylibre.com> - 2016-07-07 00:30 +0200
  [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
    Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly  non-modular Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-05 11:10 +0200
      Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-05 15:40 +0200
    Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular Geert Uytterhoeven <geert@linux-m68k.org> - 2016-07-05 13:10 +0200
      Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-05 15:20 +0200
    Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly  non-modular Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-07-07 15:20 +0200
  [PATCH 01/10] clk: meson8b: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
    Re: [PATCH 01/10] clk: meson8b: make it explicitly non-modular Michael Turquette <mturquette@baylibre.com> - 2016-07-07 00:30 +0200
  [PATCH 08/10] clk: sunxi: make clk-* explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
    Re: [PATCH 08/10] clk: sunxi: make clk-* explicitly non-modular Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-07-04 23:40 +0200
    Re: [PATCH 08/10] clk: sunxi: make clk-* explicitly non-modular Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-07-05 08:20 +0200
    Re: [PATCH 08/10] clk: sunxi: make clk-* explicitly non-modular Michael Turquette <mturquette@baylibre.com> - 2016-07-07 00:30 +0200
  [PATCH 05/10] clk: oxnas: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-04 23:20 +0200
    Re: [PATCH 05/10] clk: oxnas: make it explicitly non-modular Neil Armstrong <narmstrong@baylibre.com> - 2016-07-06 15:20 +0200
    Re: [PATCH 05/10] clk: oxnas: make it explicitly non-modular Michael Turquette <mturquette@baylibre.com> - 2016-07-07 00:30 +0200

csiph-web