Re: [alsa-devel] [PATCH 3/4] ASoC: mediatek: add BT implementation

From	Garlic Tseng <garlic.tseng@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [alsa-devel] [PATCH 3/4] ASoC: mediatek: add BT implementation
Date	2016-07-05 11:00 +0200
Message-ID	<rRun0-ty-17@gated-at.bofh.it> (permalink)
References	<rR9Lz-4Ah-3@gated-at.bofh.it> <rR9Lz-4Ah-1@gated-at.bofh.it> <rRdm9-6R8-9@gated-at.bofh.it> <rRnOx-4Kl-1@gated-at.bofh.it> <rRtKh-g7-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-07-05 at 10:12 +0200, Mark Brown wrote:
> On Tue, Jul 05, 2016 at 09:52:13AM +0800, Garlic Tseng wrote:
> > On Mon, 2016-07-04 at 16:44 +0200, Mark Brown wrote:
> 
> > > We really shouldn't be writing the registers or other internal data of
> > > the device.  Instead we should be getting the driver for the relevant
> > > hardware component to do it.  If we just write to registers that makes
> > > the interoperation with the real driver for the device more fragile than
> > > it should be, people might update the main driver without noticing the
> > > external driver.
> 
> > The AUDIO_TOP_CON4 is a reg of the ASoC hw module. All the registers
> > which are set in the btmrg operator belong to ASoC hardware. The reg
> > writing you mention above is to power up the MRG interface in the ASoC
> > module.
> 
> The problem is that this is the machine driver, not a driver for the
> chip that's being controlled.

The patch is for platform driver "mt2701-afe-pcm.c", which contorls the
ASoC module, not for machine driver. Maybe the patch sequence is
confusing and I'm sorry about that. Or did I misunderstand your comment?

Thread

[alsa-devel] [PATCH 3/4] ASoC: mediatek: add BT implementation Garlic Tseng <garlic.tseng@mediatek.com> - 2016-07-04 13:00 +0200
  Re: [alsa-devel] [PATCH 3/4] ASoC: mediatek: add BT implementation Mark Brown <broonie@kernel.org> - 2016-07-04 16:50 +0200
    Re: [alsa-devel] [PATCH 3/4] ASoC: mediatek: add BT implementation Garlic Tseng <garlic.tseng@mediatek.com> - 2016-07-05 04:00 +0200
      Re: [alsa-devel] [PATCH 3/4] ASoC: mediatek: add BT implementation Mark Brown <broonie@kernel.org> - 2016-07-05 10:20 +0200
        Re: [alsa-devel] [PATCH 3/4] ASoC: mediatek: add BT implementation Garlic Tseng <garlic.tseng@mediatek.com> - 2016-07-05 11:00 +0200
  Applied "ASoC: mediatek: add BT implementation" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-07-05 12:00 +0200

csiph-web