Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436700

Re: [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute

Show all headers | View raw

Hello Ganesh,

On (07/04/16 17:21), Ganesh Mahendran wrote:
> > On (07/04/16 14:49), Ganesh Mahendran wrote:
> > [..]
> >> -static void zs_unregister_cpu_notifier(void)
> >> +static void __exit zs_unregister_cpu_notifier(void)
> >>  {
> >
> > this __exit symbol is called from `__init zs_init()' and thus is
> > free to crash.
> 
> I change code to force the code goto notifier_fail where the
> zs_unregister_cpu_notifier will be called.
> I tested with zsmalloc module buildin and built as a module.

sorry, not sure I understand what do you mean by this.


> Please correct me, if I miss something.

you have an __exit section function being called from
__init section:

static void __exit zs_unregister_cpu_notifier(void)
{
}

static int __init zs_init(void)
{
	zs_unregister_cpu_notifier();
}

it's no good.

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-04 09:00 +0200
  [PATCH v2 4/8] mm/zsmalloc: use class->objs_per_zspage to get num of max objects Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-04 09:00 +0200
  [PATCH v2 6/8] mm/zsmalloc: keep comments consistent with code Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-04 09:00 +0200
    Re: [PATCH v2 6/8] mm/zsmalloc: keep comments consistent with code Minchan Kim <minchan@kernel.org> - 2016-07-06 04:50 +0200
  [PATCH v2 5/8] mm/zsmalloc: avoid calculate max objects of zspage twice Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-04 09:00 +0200
    Re: [PATCH v2 5/8] mm/zsmalloc: avoid calculate max objects of  zspage twice Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-07-05 03:20 +0200
    Re: [PATCH v2 5/8] mm/zsmalloc: avoid calculate max objects of  zspage twice Minchan Kim <minchan@kernel.org> - 2016-07-06 04:50 +0200
  [PATCH v2 8/8] mm/zsmalloc: use helper to clear page->flags bit Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-04 09:00 +0200
    Re: [PATCH v2 8/8] mm/zsmalloc: use helper to clear page->flags bit Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-07-04 10:50 +0200
  [PATCH v2 2/8] mm/zsmalloc: use obj_index to keep consistent with others Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-04 09:00 +0200
    Re: [PATCH v2 2/8] mm/zsmalloc: use obj_index to keep consistent  with others Minchan Kim <minchan@kernel.org> - 2016-07-06 04:40 +0200
  [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-04 09:00 +0200
    Re: [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-07-04 10:50 +0200
      Re: [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-04 11:30 +0200
        Re: [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-07-05 03:10 +0200
          Re: [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute Minchan Kim <minchan@kernel.org> - 2016-07-06 04:50 +0200
            Re: [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-06 08:30 +0200
  Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface Steven Rostedt <rostedt@goodmis.org> - 2016-07-05 19:00 +0200
  Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface Minchan Kim <minchan@kernel.org> - 2016-07-06 04:40 +0200
    Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-06 08:30 +0200

csiph-web