Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436499

Re: [PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout

Show all headers | View raw

On Mon, 27 Jun, at 12:49:20PM, Ingo Molnar wrote:
 
> The other weirdness is the misalignment of the '0xe' portion here:
> 
> #define LINUX_EFI_ARM_SCREEN_INFO_TABLE_GUID	EFI_GUID(0xe03fc20a, 0x85dc, 0x406e,  0xb9, 0xe, 0x4a, 0xb5, 0x02, 0x37, 0x1d, 0x95)
> #define LINUX_EFI_LOADER_ENTRY_GUID		EFI_GUID(0x4a67b082, 0x0a4c, 0x41cf,  0xb6, 0xc7, 0x44, 0x0b, 0x29, 0xbb, 0x8c, 0x4f)
> 
> Am I correct that LINUX_EFI_ARM_SCREEN_INFO_TABLE_GUID is purely Linux kernel 
> internal, and that we can write 0xe as 0x0e?
 
Yep, you're correct.

> The patch below implements this organization of the GUIDs on top of your patch.
> 
> Also note that it should still be easy to line up these lines with the spec, as I 
> left an extra space before the 'byte' portion of the table, so the table is 
> separated into two areas visually.

Looks fine to me, and so did Joe's checkpatch patch.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-25 09:30 +0200
  Re: [PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout Ingo Molnar <mingo@kernel.org> - 2016-06-27 12:50 +0200
    Re: [PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout Joe Perches <joe@perches.com> - 2016-06-27 13:20 +0200
    Re: [PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout Matt Fleming <matt@codeblueprint.co.uk> - 2016-07-04 15:20 +0200
    [tip:efi/core] efi: Reorganize the GUID table to make it easier to  read tip-bot for Ingo Molnar <tipbot@zytor.com> - 2016-07-08 15:30 +0200
  [tip:efi/core] efi: Document #define FOO_PROTOCOL_GUID layout tip-bot for Peter Jones <tipbot@zytor.com> - 2016-06-27 15:10 +0200

csiph-web