Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1437897

Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Dave Hansen <dave.hansen@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries
Date Wed, 06 Jul 2016 20:20:01 +0200
Message-ID <rRZAt-4ax-7@gated-at.bofh.it> (permalink)
References <rQcVb-2Ax-3@gated-at.bofh.it> <rQcVd-2Ax-81@gated-at.bofh.it>
X-Extloop1 1
X-Ironport-Av E=Sophos;i="5.28,320,1464678000"; d="scan'208";a="1011989270"
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0
MIME-Version 1.0
Content-Type text/plain; charset=windows-1252
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 14
Organization linux.* mail to news gateway
X-Original-Cc Rik van Riel <riel@surriel.com>, Vlastimil Babka <vbabka@suse.cz>, Johannes Weiner <hannes@cmpxchg.org>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date Wed, 6 Jul 2016 11:12:52 -0700
X-Original-Message-ID <577D4A24.1090800@intel.com>
X-Original-References <1467403299-25786-1-git-send-email-mgorman@techsingularity.net> <1467403299-25786-32-git-send-email-mgorman@techsingularity.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1437897

Show key headers only | View raw


On 07/01/2016 01:01 PM, Mel Gorman wrote:
> +#ifdef CONFIG_HIGHMEM
> +extern unsigned long highmem_file_pages;
> +
> +static inline void acct_highmem_file_pages(int zid, enum lru_list lru,
> +							int nr_pages)
> +{
> +	if (is_highmem_idx(zid) && is_file_lru(lru))
> +		highmem_file_pages += nr_pages;
> +}
> +#else

Shouldn't highmem_file_pages technically be an atomic_t (or atomic64_t)?
 We could have highmem on two nodes which take two different LRU locks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries Mel Gorman <mgorman@techsingularity.net> - 2016-07-01 22:10 +0200
  Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Minchan Kim <minchan@kernel.org> - 2016-07-06 02:10 +0200
    Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Mel Gorman <mgorman@techsingularity.net> - 2016-07-06 11:00 +0200
      Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Mel Gorman <mgorman@techsingularity.net> - 2016-07-06 11:40 +0200
      Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Minchan Kim <minchan@kernel.org> - 2016-07-07 08:50 +0200
  Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Dave Hansen <dave.hansen@intel.com> - 2016-07-06 20:20 +0200
    Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Mel Gorman <mgorman@techsingularity.net> - 2016-07-07 13:30 +0200

csiph-web