Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries

From	Mel Gorman <mgorman@techsingularity.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries
Date	2016-07-07 13:30 +0200
Message-ID	<rSfFf-6fa-9@gated-at.bofh.it> (permalink)
References	<rQcVb-2Ax-3@gated-at.bofh.it> <rQcVd-2Ax-81@gated-at.bofh.it> <rRZAt-4ax-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 06, 2016 at 11:12:52AM -0700, Dave Hansen wrote:
> On 07/01/2016 01:01 PM, Mel Gorman wrote:
> > +#ifdef CONFIG_HIGHMEM
> > +extern unsigned long highmem_file_pages;
> > +
> > +static inline void acct_highmem_file_pages(int zid, enum lru_list lru,
> > +							int nr_pages)
> > +{
> > +	if (is_highmem_idx(zid) && is_file_lru(lru))
> > +		highmem_file_pages += nr_pages;
> > +}
> > +#else
> 
> Shouldn't highmem_file_pages technically be an atomic_t (or atomic64_t)?
>  We could have highmem on two nodes which take two different LRU locks.

It would require a NUMA machine with highmem or very weird
configurations but sure, atomic is safer.

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries Mel Gorman <mgorman@techsingularity.net> - 2016-07-01 22:10 +0200
  Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Minchan Kim <minchan@kernel.org> - 2016-07-06 02:10 +0200
    Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Mel Gorman <mgorman@techsingularity.net> - 2016-07-06 11:00 +0200
      Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Mel Gorman <mgorman@techsingularity.net> - 2016-07-06 11:40 +0200
      Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Minchan Kim <minchan@kernel.org> - 2016-07-07 08:50 +0200
  Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Dave Hansen <dave.hansen@intel.com> - 2016-07-06 20:20 +0200
    Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting  by approximating retries Mel Gorman <mgorman@techsingularity.net> - 2016-07-07 13:30 +0200

csiph-web