Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437842

Re: [PATCH V2 05/10] firmware: tegra: add BPMP support

Show all headers | View raw

Alex,

On 07/06/2016 04:39 AM, Alexandre Courbot wrote:
>> diff --git a/include/soc/tegra/bpmp_abi.h b/include/soc/tegra/bpmp_abi.h
>> >new file mode 100644
>> >index 000000000000..0aaef5960e29
>> >--- /dev/null
>> >+++ b/include/soc/tegra/bpmp_abi.h
>> >@@ -0,0 +1,1601 @@
>> >+/*
>> >+ * Copyright (c) 2014-2016, NVIDIA CORPORATION.  All rights reserved.
>> >+ *
>> >+ * This program is free software; you can redistribute it and/or modify it
>> >+ * under the terms and conditions of the GNU General Public License,
>> >+ * version 2, as published by the Free Software Foundation.
>> >+ *
>> >+ * This program is distributed in the hope it will be useful, but WITHOUT
>> >+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
>> >+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
>> >+ * more details.
>> >+ *
>> >+ * You should have received a copy of the GNU General Public License
>> >+ * along with this program.  If not, see<http://www.gnu.org/licenses/>.
>> >+ */
>> >+
>> >+#ifndef_ABI_BPMP_ABI_H_
>> >+#define_ABI_BPMP_ABI_H_
>> >+
>>
> ...
>
> There is a lot of stuff in this file, most of which we are not using
> now - this is ok, but unless this is a file synced from an outside
> resource maybe we should trim the structures we don't need and add
> them as we make use of them? It helps dividing the work in bite-size
> chunks.
>
> Regarding the documentation format of this file, is this valid kernel
> documentation since the adoption of Sphynx? Or is it whatever the
> origin is using?
bpmp_abi.h is meant to be delivered as is from an NVIDIA internal repo 
to a variety of OS'es. Each of them has a different documentation 
standard and coding standard.

I'd like to avoid trimming parts from the file (or even worse modifying 
parts of the file) so that future deliveries are trivial.

Thanks,
Matt Longnecker

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 00/10] arm64: tegra: add BPMP support Joseph Lo <josephl@nvidia.com> - 2016-07-05 11:10 +0200
  [PATCH V2 02/10] mailbox: tegra-hsp: Add HSP(Hardware Synchronization Primitives) driver Joseph Lo <josephl@nvidia.com> - 2016-07-05 11:10 +0200
    Re: [PATCH V2 02/10] mailbox: tegra-hsp: Add HSP(Hardware  Synchronization Primitives) driver Alexandre Courbot <gnurou@gmail.com> - 2016-07-06 09:10 +0200
      Re: [PATCH V2 02/10] mailbox: tegra-hsp: Add HSP(Hardware  Synchronization Primitives) driver Joseph Lo <josephl@nvidia.com> - 2016-07-06 11:10 +0200
        Re: [PATCH V2 02/10] mailbox: tegra-hsp: Add HSP(Hardware  Synchronization Primitives) driver Alexandre Courbot <gnurou@gmail.com> - 2016-07-06 14:30 +0200
          Re: [PATCH V2 02/10] mailbox: tegra-hsp: Add HSP(Hardware  Synchronization Primitives) driver Joseph Lo <josephl@nvidia.com> - 2016-07-07 08:40 +0200
            Re: [PATCH V2 02/10] mailbox: tegra-hsp: Add HSP(Hardware  Synchronization Primitives) driver Sivaram Nair <sivaramn@nvidia.com> - 2016-07-07 23:40 +0200
        Re: [PATCH V2 02/10] mailbox: tegra-hsp: Add HSP(Hardware  Synchronization Primitives) driver Stephen Warren <swarren@wwwdotorg.org> - 2016-07-06 19:00 +0200
          Re: [PATCH V2 02/10] mailbox: tegra-hsp: Add HSP(Hardware  Synchronization Primitives) driver Joseph Lo <josephl@nvidia.com> - 2016-07-07 08:50 +0200
    Re: [PATCH V2 02/10] mailbox: tegra-hsp: Add HSP(Hardware  Synchronization Primitives) driver Sivaram Nair <sivaramn@nvidia.com> - 2016-07-07 23:20 +0200
  [PATCH V2 07/10] arm64: defconfig: Enable Tegra186 SoC Joseph Lo <josephl@nvidia.com> - 2016-07-05 11:10 +0200
  [PATCH V2 09/10] arm64: dts: tegra: Add NVIDIA Tegra186 P3310 main board support Joseph Lo <josephl@nvidia.com> - 2016-07-05 11:10 +0200
  [PATCH V2 10/10] arm64: dts: tegra: Add NVIDIA P2771 board support Joseph Lo <josephl@nvidia.com> - 2016-07-05 11:10 +0200
  [PATCH V2 04/10] firmware: tegra: add IVC library Joseph Lo <josephl@nvidia.com> - 2016-07-05 11:10 +0200
    Re: [PATCH V2 04/10] firmware: tegra: add IVC library Alexandre Courbot <gnurou@gmail.com> - 2016-07-07 13:20 +0200
    Re: [PATCH V2 04/10] firmware: tegra: add IVC library Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-10 01:50 +0200
  [PATCH V2 08/10] arm64: dts: tegra: Add Tegra186 support Joseph Lo <josephl@nvidia.com> - 2016-07-05 11:10 +0200
  [PATCH V2 06/10] soc/tegra: Add Tegra186 support Joseph Lo <josephl@nvidia.com> - 2016-07-05 11:10 +0200
  Re: [PATCH V2 03/10] Documentation: dt-bindings: firmware: tegra: add  bindings of the BPMP Alexandre Courbot <gnurou@gmail.com> - 2016-07-06 13:50 +0200
    Re: [PATCH V2 03/10] Documentation: dt-bindings: firmware: tegra: add  bindings of the BPMP Joseph Lo <josephl@nvidia.com> - 2016-07-07 08:30 +0200
  Re: [PATCH V2 05/10] firmware: tegra: add BPMP support Alexandre Courbot <gnurou@gmail.com> - 2016-07-06 14:00 +0200
    Re: [PATCH V2 05/10] firmware: tegra: add BPMP support Stephen Warren <swarren@wwwdotorg.org> - 2016-07-06 18:50 +0200
    Re: [PATCH V2 05/10] firmware: tegra: add BPMP support Matt Longnecker <mlongnecker@nvidia.com> - 2016-07-06 18:50 +0200
      Re: [PATCH V2 05/10] firmware: tegra: add BPMP support Alexandre Courbot <gnurou@gmail.com> - 2016-07-07 04:30 +0200
    Re: [PATCH V2 05/10] firmware: tegra: add BPMP support Joseph Lo <josephl@nvidia.com> - 2016-07-07 10:20 +0200
      Re: [PATCH V2 05/10] firmware: tegra: add BPMP support Alexandre Courbot <gnurou@gmail.com> - 2016-07-07 12:20 +0200
        Re: [PATCH V2 05/10] firmware: tegra: add BPMP support Stephen Warren <swarren@wwwdotorg.org> - 2016-07-07 22:00 +0200
        Re: [PATCH V2 05/10] firmware: tegra: add BPMP support Sivaram Nair <sivaramn@nvidia.com> - 2016-07-08 22:30 +0200
  Re: [PATCH V2 03/10] Documentation: dt-bindings: firmware: tegra: add  bindings of the BPMP Stephen Warren <swarren@wwwdotorg.org> - 2016-07-06 19:10 +0200
    Re: [PATCH V2 03/10] Documentation: dt-bindings: firmware: tegra: add  bindings of the BPMP Joseph Lo <josephl@nvidia.com> - 2016-07-07 08:30 +0200

csiph-web