Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1437546

Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier.

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier.
Date Wed, 06 Jul 2016 10:50:02 +0200
Message-ID <rRQGS-6SL-1@gated-at.bofh.it> (permalink)
References <rQ1do-3M7-7@gated-at.bofh.it> <rQ1wJ-3SM-19@gated-at.bofh.it> <rQ1Q5-4fw-11@gated-at.bofh.it> <rQ1ZM-4iE-21@gated-at.bofh.it> <rRQdP-6J4-3@gated-at.bofh.it>
X-Original-To Ding Tianhong <dingtianhong@huawei.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=mWUQfTMQNy+4kVhIbzIfls5QsytmTgJGT3UrveeLBn4=; b=KP9RGRoNSAwqYsHh36T3ejNqD2SJJHR/gdAHweHTT/sUeNK7KBPw2rproxWp/h/sde S2KWLfy3tI2lAxf2O3/VjtZSrtoZpKc1bxkPeDTUhqZU/i+aCvWhRKbfHKF7YhV+EguR VklvDvdogMPIljNCu+LUcy0YqQGQy5/g7uFFHAm23YOmOThdko1v/gOnoSnlMaECXOF1 ZN6PH+LQ5lbDPA4bRpELteNjFTAk32oBWJKMnksLh2JpqYzXqpM+k1p94RjN0sJLT/vD JbRiS2AlRyEIBhVHX1AqT5652DMU8o0dml+qs0EAWEfNGXJddWE/HQcCHIRBLbVbKYHV ufHw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=mWUQfTMQNy+4kVhIbzIfls5QsytmTgJGT3UrveeLBn4=; b=KfkOHtkjQoeIA/kUOICjP8JJEIpW2Tga/kJ9j5N7FDjmNDmH7C+8wsY7ka4OqCFR1Q VhEnvitLKCV9kRe0YTCKW3erm1CM4IxnQmy0sbARFReottYKewZ2XkYZKaCdFH+87r+H cUJLoCcAexXr2s5AfbzGto6ubKlS3Kq60S637HqqTPeXpQHgG+AqV/Cf7nkTBRruqHVn NcOrdv1UoCARfJPUgbG3VTuzqlEJ/GbM34yTq00zbLVaOLQjLrK7QaDfH9TqohvE/mH8 hNOlqxA0YN8MjkWMcTFokLSCbYubOK8ns1bWP+1rGgJEzWsih39Sj3HJ9K2pfoybYZqP ASiA==
X-Gm-Message-State ALyK8tJcctZg5tcac1zltKqqEb1ruje7vfJQ1SMe1yObhP5NopYnzdHRj7yFmpy8xK9bNA==
X-Received by 10.202.104.142 with SMTP id o14mr12392003oik.130.1467794651043; Wed, 06 Jul 2016 01:44:11 -0700 (PDT)
Content-Type text/plain; charset="UTF-8"
X-Mailer Evolution 3.10.4-0ubuntu2
MIME-Version 1.0
Content-Transfer-Encoding 8bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 25
Organization linux.* mail to news gateway
X-Original-Cc luto@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>, "David S. Miller" <davem@davemloft.net>, Netdev <netdev@vger.kernel.org>, Cong Wang <cwang@twopensource.com>
X-Original-Date Wed, 06 Jul 2016 10:44:04 +0200
X-Original-Message-ID <1467794644.1273.17.camel@edumazet-glaptop3.roam.corp.google.com>
X-Original-References <57761E04.8030202@huawei.com> <1467359847.11238.34.camel@edumazet-glaptop3.roam.corp.google.com> <5776258F.6080008@huawei.com> <1467361396.11238.35.camel@edumazet-glaptop3.roam.corp.google.com> <577CBE0E.1050809@huawei.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1437546

Show key headers only | View raw


On Wed, 2016-07-06 at 16:15 +0800, Ding Tianhong wrote:
> Hi Eric:
> 
> I had found out that the patch aaf92f(netfilter: conntrack: resched in
> nf_ct_iterate_cleanup) solve the problem, 
> this patch add cond_sched() in the nf_ct_iterate_cleanup() which will
> be called in the net notifier chain every time,
> and I revert this patch at kernel 4.7-rc4 , it will panic for soft
> lockup, so I am not sure whether our patch is need,
> it looks like if I disable the CONFIG for netfilter that would
> register the nf_ct_iterate_cleanup as notifier, the problem still be
> exist.

Well, I do not have conntrack on my kernels, and I can not reproduce the
issue.

So I am guessing other patches also solved a scalability issue, between
4.1 and 4.7

I am aware of something that David did for IPv4, but this might help as
well for IPv6.

commit fbd40ea0180a2d328c5adc61414dc8bab9335ce2
ipv4: Don't do expensive useless work during inetdev destroy.
    

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Ding Tianhong <dingtianhong@huawei.com> - 2016-07-01 09:40 +0200
  Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Eric Dumazet <eric.dumazet@gmail.com> - 2016-07-01 10:00 +0200
    Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Ding Tianhong <dingtianhong@huawei.com> - 2016-07-01 10:20 +0200
      Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Eric Dumazet <eric.dumazet@gmail.com> - 2016-07-01 10:30 +0200
        Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Ding Tianhong <dingtianhong@huawei.com> - 2016-07-06 10:20 +0200
          Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Eric Dumazet <eric.dumazet@gmail.com> - 2016-07-06 10:50 +0200
            Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Ding Tianhong <dingtianhong@huawei.com> - 2016-07-07 03:50 +0200

csiph-web