Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1435100

Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier.

From Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier.
Date 2016-07-01 10:00 +0200
Message-ID <rQ1wJ-3SM-19@gated-at.bofh.it> (permalink)
References <rQ1do-3M7-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 2016-07-01 at 15:38 +0800, Ding Tianhong wrote:
...
>  net/ipv6/addrconf.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index f555f4f..e294a3d 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3284,6 +3284,12 @@ restart:
>  		spin_unlock_bh(&addrconf_hash_lock);
>  	}
>  
> +	/*
> +	 * It is safe here to schedule out to avoid softlocking if preempt
> +	 * is disabled.
> +	 */
> +	cond_resched();
> +
>  	write_lock_bh(&idev->lock);
>  
>  	addrconf_del_rs_timer(idev);

Seeing you apparently cooked your patch against an old kernel (which
one ?) ...

I tried vanilla net-next kernel, and apparently I could not trigger the
softlockup you mentioned.

Are you sure current kernel has a bug to begin with ?

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Ding Tianhong <dingtianhong@huawei.com> - 2016-07-01 09:40 +0200
  Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Eric Dumazet <eric.dumazet@gmail.com> - 2016-07-01 10:00 +0200
    Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Ding Tianhong <dingtianhong@huawei.com> - 2016-07-01 10:20 +0200
      Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Eric Dumazet <eric.dumazet@gmail.com> - 2016-07-01 10:30 +0200
        Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Ding Tianhong <dingtianhong@huawei.com> - 2016-07-06 10:20 +0200
          Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Eric Dumazet <eric.dumazet@gmail.com> - 2016-07-06 10:50 +0200
            Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier. Ding Tianhong <dingtianhong@huawei.com> - 2016-07-07 03:50 +0200

csiph-web