Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1437492

[PATCH v4 2/7] xen-pciback: drop rom_init()

From "Jan Beulich" <JBeulich@suse.com>
Newsgroups linux.kernel
Subject [PATCH v4 2/7] xen-pciback: drop rom_init()
Date 2016-07-06 09:00 +0200
Message-ID <rROYp-5Ma-5@gated-at.bofh.it> (permalink)
References <rROOJ-5IG-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


It is now identical to bar_init().

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
 drivers/xen/xen-pciback/conf_space_header.c |   14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

--- 4.7-rc6-xen-pciback.orig/drivers/xen/xen-pciback/conf_space_header.c
+++ 4.7-rc6-xen-pciback/drivers/xen/xen-pciback/conf_space_header.c
@@ -252,18 +252,6 @@ static void *bar_init(struct pci_dev *de
 	return bar;
 }
 
-static void *rom_init(struct pci_dev *dev, int offset)
-{
-	struct pci_bar_info *bar = kzalloc(sizeof(*bar), GFP_KERNEL);
-
-	if (!bar)
-		return ERR_PTR(-ENOMEM);
-
-	read_dev_bar(dev, bar, offset);
-
-	return bar;
-}
-
 static void bar_reset(struct pci_dev *dev, int offset, void *data)
 {
 	struct pci_bar_info *bar = data;
@@ -382,7 +370,7 @@ static const struct config_field header_
 	{						\
 	.offset     = reg_offset,			\
 	.size       = 4,				\
-	.init       = rom_init,				\
+	.init       = bar_init,				\
 	.reset      = bar_reset,			\
 	.release    = bar_release,			\
 	.u.dw.read  = bar_read,				\

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 0/7] xen-pciback: misc cleanup "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 08:50 +0200
  [PATCH v4 2/7] xen-pciback: drop rom_init() "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 3/7] xen-pciback: fold read_dev_bar() into its now  single caller "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 1/7] xen-pciback: drop unused function parameter of  read_dev_bar() "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 4/7] xen-pciback: simplify determination of 64-bit  memory resource "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 6/7] xen-pciback: short-circuit read path used for  merging write values "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 5/7] xen-pciback: use const and unsigned in  bar_init() "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 7/7] xen-pciback: drop superfluous variables "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:10 +0200
  Re: [Xen-devel] [PATCH v4 0/7] xen-pciback: misc cleanup David Vrabel <david.vrabel@citrix.com> - 2016-07-06 11:50 +0200

csiph-web