Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437497

[PATCH v4 6/7] xen-pciback: short-circuit read path used for merging write values

Show all headers | View raw

There's no point calling xen_pcibk_config_read() here - all it'll do is
return whatever conf_space_read() returns for the field which was found
here (and which would be found there again). Also there's no point
clearing tmp_val before the call.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
 drivers/xen/xen-pciback/conf_space.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- 4.7-rc6-xen-pciback.orig/drivers/xen/xen-pciback/conf_space.c
+++ 4.7-rc6-xen-pciback/drivers/xen/xen-pciback/conf_space.c
@@ -230,10 +230,8 @@ int xen_pcibk_config_write(struct pci_de
 		field_end = OFFSET(cfg_entry) + field->size;
 
 		 if (req_end > field_start && field_end > req_start) {
-			tmp_val = 0;
-
-			err = xen_pcibk_config_read(dev, field_start,
-						  field->size, &tmp_val);
+			err = conf_space_read(dev, cfg_entry, field_start,
+					      &tmp_val);
 			if (err)
 				break;
 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/7] xen-pciback: misc cleanup "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 08:50 +0200
  [PATCH v4 2/7] xen-pciback: drop rom_init() "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 3/7] xen-pciback: fold read_dev_bar() into its now  single caller "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 1/7] xen-pciback: drop unused function parameter of  read_dev_bar() "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 4/7] xen-pciback: simplify determination of 64-bit  memory resource "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 6/7] xen-pciback: short-circuit read path used for  merging write values "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 5/7] xen-pciback: use const and unsigned in  bar_init() "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:00 +0200
  [PATCH v4 7/7] xen-pciback: drop superfluous variables "Jan Beulich" <JBeulich@suse.com> - 2016-07-06 09:10 +0200
  Re: [Xen-devel] [PATCH v4 0/7] xen-pciback: misc cleanup David Vrabel <david.vrabel@citrix.com> - 2016-07-06 11:50 +0200

csiph-web