Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437289

Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release

From Paolo Bonzini <pbonzini@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release
Date 2016-07-05 23:20 +0200
Message-ID <rRFV7-8fV-1@gated-at.bofh.it> (permalink)
References (4 earlier) <rRDJD-6BU-21@gated-at.bofh.it> <rREw1-7cF-7@gated-at.bofh.it> <rREFI-7gf-31@gated-at.bofh.it> <rREPn-7zl-1@gated-at.bofh.it> <rRFBM-7Sm-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 05/07/2016 22:53, Christian Borntraeger wrote:
> Yes, this is new in next. As far as I can see, the new message would only
> appear if we would call ratelimit_state_exit. Correct? We do not call this -
> I assume this is ok?
> 
> We really only want to reuse the rate limit base code (to avoid writing the same
> code twice) and being in lib indicated that this can indeed be used outside
> printk.
> Now: your patch 1 would allow me to get rid of the messages completely
> by setting the flag and by not calling ratelimit_state_exit. Which is probably
> what we should do in our code.

Can we delay fixing this after the code is merged in Linus's tree?

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release Borislav Petkov <bp@alien8.de> - 2016-07-04 16:30 +0200
  Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Steven Rostedt <rostedt@goodmis.org> - 2016-07-05 20:30 +0200
    Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Borislav Petkov <bp@alien8.de> - 2016-07-05 20:50 +0200
      Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Steven Rostedt <rostedt@goodmis.org> - 2016-07-05 21:00 +0200
        Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Borislav Petkov <bp@alien8.de> - 2016-07-05 21:50 +0200
          Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Steven Rostedt <rostedt@goodmis.org> - 2016-07-05 22:00 +0200
            Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Joe Perches <joe@perches.com> - 2016-07-05 22:10 +0200
              Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on  release Christian Borntraeger <borntraeger@de.ibm.com> - 2016-07-05 23:00 +0200
                Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on  release Paolo Bonzini <pbonzini@redhat.com> - 2016-07-05 23:20 +0200
                Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on  release Christian Borntraeger <borntraeger@de.ibm.com> - 2016-07-05 23:30 +0200
                Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Borislav Petkov <bp@alien8.de> - 2016-07-05 23:40 +0200
  [PATCH -v3.1 1/2] ratelimit: Extend to print suppressed messages on  release Borislav Petkov <bp@alien8.de> - 2016-07-06 15:30 +0200
    Re: [PATCH -v3.1 1/2] ratelimit: Extend to print suppressed  messages on release Steven Rostedt <rostedt@goodmis.org> - 2016-07-06 15:50 +0200
      [PATCH -v3.2 1/2] ratelimit: Extend to print suppressed messages on  release Borislav Petkov <bp@alien8.de> - 2016-07-06 17:00 +0200
        Re: [PATCH -v3.2 1/2] ratelimit: Extend to print suppressed  messages on release Steven Rostedt <rostedt@goodmis.org> - 2016-07-07 03:20 +0200
          Re: [PATCH -v3.2 1/2] ratelimit: Extend to print suppressed messages  on release Borislav Petkov <bp@alien8.de> - 2016-07-07 07:40 +0200
    Re: [PATCH -v3.1 1/2] ratelimit: Extend to print suppressed  messages on release Joe Perches <joe@perches.com> - 2016-07-06 17:00 +0200

csiph-web