Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1437251

Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release
Date 2016-07-05 22:10 +0200
Message-ID <rREPn-7zl-1@gated-at.bofh.it> (permalink)
References (2 earlier) <rRDgC-6pN-15@gated-at.bofh.it> <rRDzX-6xV-9@gated-at.bofh.it> <rRDJD-6BU-21@gated-at.bofh.it> <rREw1-7cF-7@gated-at.bofh.it> <rREFI-7gf-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 2016-07-05 at 15:49 -0400, Steven Rostedt wrote:
> On Tue, 5 Jul 2016 21:42:45 +0200 Borislav Petkov <bp@alien8.de> wrote:
> > On Tue, Jul 05, 2016 at 02:57:32PM -0400, Steven Rostedt wrote:
> > > Perhaps we should show both, unless you don't think this will ever be
> > > used by anything other than devkmsg?  
> > I'd say let's do it only when we go down that road and start using it
> > for something else.
> > 
> > Because, for example, the ratelimiting thing is, in fact, generic but it
> > is used primarily to ratelimit printks. Even though it could be used for
> > something else, theoretically...
> > 
> But you know... Build it and they will come.

arch/s390/kvm/kvm-s390.c:       ratelimit_state_init(&kvm->arch.sthyi_limit, 5 * HZ, 500);

As far as I know, _ratelimit is used for non-printk purposes in
arch/s390/kvm/sthyi.c

int handle_sthyi(struct kvm_vcpu *vcpu)
{
	int reg1, reg2, r = 0;
	u64 code, addr, cc = 0;
	struct sthyi_sctns *sctns = NULL;

	/*
	 * STHYI requires extensive locking in the higher hypervisors
	 * and is very computational/memory expensive. Therefore we
	 * ratelimit the executions per VM.
	 */
	if (!__ratelimit(&vcpu->kvm->arch.sthyi_limit)) {
		kvm_s390_retry_instr(vcpu);
		return 0;
	}

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release Borislav Petkov <bp@alien8.de> - 2016-07-04 16:30 +0200
  Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Steven Rostedt <rostedt@goodmis.org> - 2016-07-05 20:30 +0200
    Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Borislav Petkov <bp@alien8.de> - 2016-07-05 20:50 +0200
      Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Steven Rostedt <rostedt@goodmis.org> - 2016-07-05 21:00 +0200
        Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Borislav Petkov <bp@alien8.de> - 2016-07-05 21:50 +0200
          Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Steven Rostedt <rostedt@goodmis.org> - 2016-07-05 22:00 +0200
            Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Joe Perches <joe@perches.com> - 2016-07-05 22:10 +0200
              Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on  release Christian Borntraeger <borntraeger@de.ibm.com> - 2016-07-05 23:00 +0200
                Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on  release Paolo Bonzini <pbonzini@redhat.com> - 2016-07-05 23:20 +0200
                Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on  release Christian Borntraeger <borntraeger@de.ibm.com> - 2016-07-05 23:30 +0200
                Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages  on release Borislav Petkov <bp@alien8.de> - 2016-07-05 23:40 +0200
  [PATCH -v3.1 1/2] ratelimit: Extend to print suppressed messages on  release Borislav Petkov <bp@alien8.de> - 2016-07-06 15:30 +0200
    Re: [PATCH -v3.1 1/2] ratelimit: Extend to print suppressed  messages on release Steven Rostedt <rostedt@goodmis.org> - 2016-07-06 15:50 +0200
      [PATCH -v3.2 1/2] ratelimit: Extend to print suppressed messages on  release Borislav Petkov <bp@alien8.de> - 2016-07-06 17:00 +0200
        Re: [PATCH -v3.2 1/2] ratelimit: Extend to print suppressed  messages on release Steven Rostedt <rostedt@goodmis.org> - 2016-07-07 03:20 +0200
          Re: [PATCH -v3.2 1/2] ratelimit: Extend to print suppressed messages  on release Borislav Petkov <bp@alien8.de> - 2016-07-07 07:40 +0200
    Re: [PATCH -v3.1 1/2] ratelimit: Extend to print suppressed  messages on release Joe Perches <joe@perches.com> - 2016-07-06 17:00 +0200

csiph-web